286881 - In <newsblog.js>, 2 "Warning: trailing comma is not legal in ECMA-262 object initializers"

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla Thunderbird, version 1.0+ (20050319)] (nightly) (W98SE)

{{
Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: file:///W:/PROGRAM%20FILES/MOZILLA%20THUNDERBIRD/components/newsblog.js
Line: 281
Source Code:
};

Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: file:///W:/PROGRAM%20FILES/MOZILLA%20THUNDERBIRD/components/newsblog.js
Line: 361, Column: 2
Source Code:
  },
}}

when starting TB.

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <newsblog.js> [Checked in: Comment 8 and 9]

[Mozilla Thunderbird, version 1.0+ (20050319)] (nightly) (W98SE)

Could you review/check in this patch ? Thanks.

Comment 2

[Serge Gautherie (:sgautherie)]

Brendan,
it seems that the line (number) for this warning should be 1 less:
is it something fixable ?

Comment 3

[Brendan Eich [:brendan]]

Serge, this isn't easy to fix.  The SpiderMonkey lexical scanner was designed to
point to an offending token in the currently-buffered line.  I'd rather fix this
by bootstrapping the next-gen JS front end (Narcissus).  If you want to file a
bug on this assigned to [e-mail], feel free and cc: me.

/be

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> If you want to file a
> bug on this assigned to [e-mail], feel free and cc: me.

I filed Bug 286937:
"Warning: trailing comma is not legal in ECMA-262 object initializers" Line and
Source Code should be the preceding line

Comment 5

[Henrik Gemal]

has this patch landed yet on the trunk? it not could someone check it in, since
it has both r= and sr=

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #5)
> has this patch landed yet on the trunk? it not could someone check it in, since
> it has both r= and sr=

See '[checkin-needed]' and 'asa: approval-aviary1.1a1-' ... I'm helpless.

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 177979 [details] [diff] [review]
(Av1) <newsblog.js>
[Checked in: Comment 8 and 9]


'approval-aviary1.1a2=?':
Trivial JS code cleanup, no risk.

Comment 8

[Brian Ryner (not reading)]

checked in

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 177979 [details] [diff] [review]
(Av1) <newsblog.js>
[Checked in: Comment 8 and 9]


Brian checked it in without the ";" removal.
I won't bother.