286893 - Some more JS warnings...

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla Thunderbird, version 1.0+ (20050319)] (nightly) (W98SE)

Tools > Options
{{
Warning: redeclaration of var keyClose
Source File: chrome://global/content/bindings/preferences.xml
Line: 457, Column: 14
Source Code:
          var keyClose = document.getAnonymousElementByAttribute(this, "anonid",
"keyClose");

Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: chrome://messenger/content/preferences/general.js
Line: 106
Source Code:
};
}}

Comment 1

[Serge Gautherie (:sgautherie)]

Then, clicking on Display
{{
Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: chrome://messenger/content/preferences/display.js
Line: 56
Source Code:
};

Error: Error in parsing value for property 'background-color'.  Declaration dropped.
Source File: chrome://messenger/content/preferences/preferences.xul
Line: 0
}}

Comment 2

[Serge Gautherie (:sgautherie)]

Then, clicking on Privacy
{{
Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: chrome://messenger/content/preferences/privacy.js
Line: 106
Source Code:
};
}}

Comment 3

[Serge Gautherie (:sgautherie)]

Then, clicking on Attachements
{{
Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: chrome://messenger/content/preferences/downloads.js
Line: 136
Source Code:
};
}}

Comment 4

[Serge Gautherie (:sgautherie)]

Then, clicking on Advanced
{{
Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: chrome://messenger/content/preferences/advanced.js
Line: 98
Source Code:
};
}}

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) (for review only) [Checkin: See comment 6]

[Mozilla Thunderbird, version 1.0+ (20050319)] (nightly) (W98SE)

Warning fixes,
plus some var removals, and a few nit fixes.

Comment 6

[Scott MacGregor]

Comment on attachment 178006 [details] [diff] [review]
(Av1) (for review only)
[Checkin: See comment 6]

you'll need moa for the toolkit change.

I checked in the mozilla/mail stuff.

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) additional space savings

The space savings which were not included in Av1...

Comment 8

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1b) additional space savings [Rejected in comment 11]

(Bv1 was missing a file.)

Comment 9

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1) Toolkit part

Av1 Toolkit part, updated to Trunk, and with full diff.

Keeping
{{
Av1) (for review only)		 patch		2005-03-19 18:01 PDT	12.47
KB	  mscott: review+
}}

Could you super-review="moa"/check in this patch ? Thanks.

Comment 10

[Scott MacGregor]

moving JS warning bugs off the blocker list

Comment 11

[Scott MacGregor]

Comment on attachment 186863 [details] [diff] [review]
(Bv1b) additional space savings
[Rejected in comment 11]

i'm not interested in making  white space only changes.

Comment 12

[Brian Ryner (not reading)]

Comment on attachment 186870 [details] [diff] [review]
(Cv1) Toolkit part

As-is, this patch has way too many whitespace-only changes.  Those clutter up cvsblame and don't really help anything.  I would be ok with a version of this that just fixes the variable redeclaration warning.

Comment 13

[Serge Gautherie (:sgautherie)]

Attachment: (Cv2-w) Toolkit part [Rejected in comment 14]

Cv1, with comment 12 suggestion(s).

The initial |Warning: redeclaration of var keyClose| was fixed (by code removal) in |1.44	mozilla.mano%sent.com	2006-01-01 02:58	 	Bug 315195 - Select wrong default font if I close the preferences window with Command + W shortcut. r=mconnor|.

Comment 14

[Brian Ryner (not reading)]

Comment on attachment 212386 [details] [diff] [review]
(Cv2-w) Toolkit part
[Rejected in comment 14]

In that case, I don't see much point in this patch.  Temporary variables for clarity are not errors.

Comment 15

[Serge Gautherie (:sgautherie)]

Dropping the 'background-color' error from comment 1, for the context of this bug.