286899 - computed value for 'cursor' should follow CSS2.1, not css3-ui

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

CSS2.1 and css3-ui disagree about the computed value of the cursor property:
  http://www.w3.org/TR/2004/CR-css3-ui-20040511/#cursor
  http://www.w3.org/TR/2004/CR-CSS21-20040225/ui.html#cursor-props

I think we should act as if they both said what I think CSS2.1 intended to say,
which is:
  Computed Value: As specified, except with any relative URLs converted to
  absolute.

I've emailed the CSS WG about this, but getting clarification might take a
while, and I think CSS2.1 is more consistent with the general definition of
computed values:
http://lists.w3.org/Archives/Member/w3c-css-wg/2005JanMar/0233 (W3C member only)

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

This also converts a CallQI to an NS_ADDREF, since the desired interface is a
supertype of the declared type of the object.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 177999 [details] [diff] [review]
patch

>+      PRBool success = valueList->AppendCSSValue(val);
>+      if (!success) {

I'd prefer not having a variable here (just "if (!valueList..."), but I don't
care that much.  (Two of these.)

>-  return CallQueryInterface(val, aValue);
>+  NS_ADDREF(*aValue = valueList);
>+  return NS_OK;

Probably better to use CallQueryInterface like all the rest, just for
consistency.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

comments addressed. (Interestingly, another place in this file also has the
success variable, even with the same name! (GetBorderColorsFor))

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in layout/style/nsComputedDOMStyle.cpp;
/cvsroot/mozilla/layout/style/nsComputedDOMStyle.cpp,v  <--  nsComputedDOMStyle.cpp
new revision: 1.137; previous revision: 1.136
done
Checking in layout/style/nsDOMCSSValueList.h;
/cvsroot/mozilla/layout/style/nsDOMCSSValueList.h,v  <--  nsDOMCSSValueList.h
new revision: 1.4; previous revision: 1.3
done