286901 - titledbutton dosen't exist anymore

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Joel Nackman]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050316 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050316 Firefox/1.0+

This doc uses <titledbutton>, which dosen't exist anymore.  In addition, it used
the right, left, and middle values for the attribute crop which are all
deprecated.  It also incorrectly used value where the attribute label should
have been.  I am attaching a patch.

Reproducible: Always

Steps to Reproduce:
1.  Go to the URL.

Comment 1

[Joel Nackman]

Attachment: A Patch

This will fix the problems.

Comment 2

[fantasai]

bz tends to focus more on C++ core, so switching your review request to neil

Comment 3

[[e-mail]]

Comment on attachment 177992 [details] [diff] [review]
A Patch

Well, it's an improvement, but there are some minor nits:
1. We have two sorts of buttons, regular buttons and toolbarbuttons
2. The regular button may contain arbitrary content
3. The pressed state is now the checked="true" attribute (there is no mixed
state)
4. crop="end" removes characters from the end of the string

Comment 4

[Joel Nackman]

Attachment: Updated Patch

I made the suggested changes and attached an updated patch.

Comment 5

[[e-mail]]

Comment on attachment 178054 [details] [diff] [review]
Updated Patch

>   The button's cropping style can be specified using
>   an attribute.  The attribute is called <code>crop</code>, and it
>-  has values of <code>left</code>, <code>middle</code>, and
>-  <code>right</code>.
>-  For example, with crop right, the string is
>+  has values of start, center, and end.
>+  For example, with crop end, the string is
>   truncated by removing characters on the right hand side of
Shouldn't these values be inside <code>? Over to fantasai to check on the
formatting.

Also describing crop="end" as removing characters from the end of the string
will endear you to RTL users.

Comment 6

[fantasai]

Comment on attachment 178054 [details] [diff] [review]
Updated Patch

Yes, all attribute values should also be in <code>. This includes 'normal',
'reverse', 'true', 'start', 'center', and 'end'.

  'with crop end'
should probably be
  'with <code>crop="end"</code>'

I have to say, you got lucky Anne already revamped the markup before you asked
me for review. :)
(You can see his changes in the Document History.)

Comment 7

[Joel Nackman]

Attachment: Updated Patch (Again)

Third time's a charm.  I made all the suggested changes.

Comment 8

[fantasai]

 <p>The button can be locked into a pressed state
  by setting the <code>checked</code> attribute on the button to a value of
  true. This attribute, when true, indicates that the button should appear in
  a depressed state.

What does "setting the <code>checked</code> attribute on the button to a value
of true" mean?

Comment 9

[Joel Nackman]

(In reply to comment #8)
>  <p>The button can be locked into a pressed state
>   by setting the <code>checked</code> attribute on the button to a value of
>   true. This attribute, when true, indicates that the button should appear in
>   a depressed state.
> 
> What does "setting the <code>checked</code> attribute on the button to a value
> of true" mean?

Here's an example:

<button label="Example" checked="true" />

Comment 10

[fantasai]

Comment on attachment 178189 [details] [diff] [review]
Updated Patch (Again)

So, in that case, 'true' should have been in <code> as well.

Comment 11

[fantasai]

Fix checked in, with that change.