286930 - POP3 Header-Only download UI regression

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Howard Chu]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050318
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050318

This has broken between the 20050111 Alpha and 1.8b2.

   With header-only mode enabled, downloading the full messages using the
"Download Selected Messages" command no longer replaces the stub in the
messagepane window with the downloaded message, nor does it select any of the
messages in the threadpane. It deletes the stub message but the stub remains in
the messagepane.

   Looking at the diff's between 2005/01/11 and today my only guess is that
changes in nsPop3Sink.cpp for the tempfiledownload feature are responsible, it
must be messing up the msgDB so that the saved information about the message
headers is no longer valid / selectable.

Reproducible: Always

Steps to Reproduce:
1.Select "Fetch Headers Only" in POP3 server settings
2.Get New messages, receiving only the stub headers.
3.Select stub(s).
4.Right-click on selected messages, do Get Selected Messages

Actual Results:  
The messages are downloaded, and the stubs are deleted, but the selected stub in
the MessagePane remains, and no messages are selected in the threadpane.

Expected Results:  
The full message corresponding to the first selected stub should be selected in
the threadpane and appear in the messagepane.

Comment 1

[Howard Chu]

Attachment: Simple fix

A PublishMsgHeader call was deleted and replaced by a block of code, but that
block was only executed if the m_downloadingToTempFile preference was True.
Obviously the original call is still needed if the preference is False.

Comment 2

[David :Bienvenu]

Comment on attachment 178028 [details] [diff] [review]
Simple fix

thx, Howard. Sorry about that...

Comment 3

[chris hofmann]

Comment on attachment 178028 [details] [diff] [review]
Simple fix

a=chofmann