286957 - bump copyright year in browser/app/nsBrowserApp.cpp

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Chase Phillips]

The copyright year needs to be bumped in browser/app/nsBrowserApp.cpp.

Comment 1

[Chase Phillips]

Nominating blocking-aviary1.0.3 and blocking-aviary1.1.

Comment 2

[zmanji]

Attachment: patch

patch

Comment 3

[Steffen Wilberg]

Comment on attachment 178088 [details] [diff] [review]
patch

Always request a review from somebody.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 178088 [details] [diff] [review]
patch

Did you put this in release-checklist?	And should it be 2004-2005 instead of
just replacing with 2005?

Comment 5

[Steffen Wilberg]

> Did you put this in release-checklist?
I did.

> And should it be 2004-2005 instead of just replacing with 2005?
Hmm, probably. Or 1998-2005, like the about dialog?

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

That depends what it's describing the copyright of.  What is it describing? :-)

Comment 7

[Steffen Wilberg]

This string is displayed when typing "firefox -v" on the command line:
Mozilla Firefox 1.0, Copyright (c) 2004 mozilla.org

I'd say this is describing Firefox, which didn't exist back in 1998. The first
release was in 2004, so it should be (c) 2004-2005. On the other hand, the About
dialog in both Firefox and Thunderbird display (c) 1998-2005. This should
probably be consistent. But im not an expert in copyright law, so I don't know
which one to pick. CC'ing Mitchell and Gerv.

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 178088 [details] [diff] [review]
patch

not making 1.0.3, try later.

I don't think this copyright is correct. It should match the about screen one
way or another. "Firefox" may be recent, but the copyrighted code includes bits
that have been around a lot longer.

Comment 9

[Steffen Wilberg]

Attachment: match the about dialog: 1998 - 2005

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(That said, the copyright owner there is actually wrong too, since copyright is
still generally held by contributors.)

Comment 11

[Chase Phillips]

Comment on attachment 180354 [details] [diff] [review]
match the about dialog: 1998 - 2005

Landed on the Aviary1.0.1 branch.

Checking in browser/app/nsBrowserApp.cpp;
/cvsroot/mozilla/browser/app/nsBrowserApp.cpp,v  <--  nsBrowserApp.cpp
new revision: 1.10.4.3.6.1; previous revision: 1.10.4.3
done

Comment 12

[Chase Phillips]

blocking-aviary1.0.3+, blocking-aviary1.0.4-

added fixed-aviary1.0.3 keyword

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 180354 [details] [diff] [review]
match the about dialog: 1998 - 2005

a=asa

Comment 14

[Chase Phillips]

Comment on attachment 180354 [details] [diff] [review]
match the about dialog: 1998 - 2005

Landed on the trunk.

Checking in browser/app/nsBrowserApp.cpp;
/cvsroot/mozilla/browser/app/nsBrowserApp.cpp,v  <--  nsBrowserApp.cpp
new revision: 1.24; previous revision: 1.23
done

Comment 15

[Chase Phillips]

Resolving fixed.  Please file any issues related to changing our established
behaviour in what we print as a copyright message in a new bug.

Comment 16

[sairuh (rarely reading bugmail)]

vrfy'd fixed in trunk and branch via lxr.