Closed Bug 286980 Opened 20 years ago Closed 20 years ago

cairo config should add to PKG_CONFIG_PATH, not replace

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: tor, Assigned: tor)

Details

Attachments

(3 files)

add instead of replace
1.09 KB, patch
cls
: review-
Details | Diff | Splinter Review
split export
1.11 KB, patch
cls
: review+
Details | Diff | Splinter Review
could have sworn I tested the split...
1.07 KB, patch
cls
: review+
Details | Diff | Splinter Review
Comment on attachment 178078 [details] [diff] [review] add instead of replace |export FOO=BAR| is a bash-ism. The command should be broken up into its separate components since it's not portable.
Attachment #178078 - Flags: review-
Attached patch split export — — Splinter Review
Attachment #178084 - Flags: review+
Checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
+ export $PKG_CONFIG_PATH not export PKG_CONFIG_PATH?
Attachment #178119 - Flags: review?(cls)
Comment on attachment 178119 [details] [diff] [review] could have sworn I tested the split... Whoops. I obviously need to just stay in my cave.
Attachment #178119 - Flags: review?(cls) → review+
Fix checked in - thanks for noticing that.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: