Closed
Bug 286990
Opened 20 years ago
Closed 20 years ago
nsHttpNegotiateAuth.cpp behaves different in debug/non-debug
Categories
(Core :: Networking: HTTP, defect)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: Biesinger, Assigned: Biesinger)
References
()
Details
Attachments
(1 file)
|
991 bytes,
patch
|
darin.moz
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
near line 219:
#ifdef DEBUG
PRBool isGssapiAuth =
!PL_strncasecmp(challenge, kNegotiate, kNegotiateLen);
NS_ENSURE_TRUE(isGssapiAuth, NS_ERROR_UNEXPECTED);
#endif
So, that NS_ENSURE_TRUE will be done in debug builds only, so those builds will
behave differently... maybe this should just be an assertion?
|
||
Comment 1•20 years ago
|
||
sure.. want to cut a patch?
|
Assignee | |
Comment 2•20 years ago
|
||
sure... why not :)
Assignee: darin → cbiesinger
Status: NEW → ASSIGNED
Attachment #178154 -
Flags: superreview?(darin)
Attachment #178154 -
Flags: review?(darin)
|
|
Assignee | |
Updated•20 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta2
|
|
||
Updated•20 years ago
|
Attachment #178154 -
Flags: superreview?(darin)
Attachment #178154 -
Flags: superreview+
Attachment #178154 -
Flags: review?(darin)
Attachment #178154 -
Flags: review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Checking in extensions/negotiateauth/nsHttpNegotiateAuth.cpp;
/cvsroot/mozilla/extensions/negotiateauth/nsHttpNegotiateAuth.cpp,v <--
nsHttpNegotiateAuth.cpp
new revision: 1.5; previous revision: 1.4
done
(oops... must've marked this fixed accidentally)
You need to log in
before you can comment on or make changes to this bug.
Description
•