nsHttpNegotiateAuth.cpp behaves different in debug/non-debug

RESOLVED FIXED in mozilla1.8beta2

Status

()

RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

Trunk
mozilla1.8beta2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

near line 219:
#ifdef DEBUG
    PRBool isGssapiAuth =
        !PL_strncasecmp(challenge, kNegotiate, kNegotiateLen);
    NS_ENSURE_TRUE(isGssapiAuth, NS_ERROR_UNEXPECTED);
#endif

So, that NS_ENSURE_TRUE will be done in debug builds only, so those builds will
behave differently... maybe this should just be an assertion?

Comment 1

14 years ago
sure.. want to cut a patch?
Created attachment 178154 [details] [diff] [review]
patch

sure... why not :)
Assignee: darin → cbiesinger
Status: NEW → ASSIGNED
Attachment #178154 - Flags: superreview?(darin)
Attachment #178154 - Flags: review?(darin)
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta2

Updated

14 years ago
Attachment #178154 - Flags: superreview?(darin)
Attachment #178154 - Flags: superreview+
Attachment #178154 - Flags: review?(darin)
Attachment #178154 - Flags: review+
Checking in extensions/negotiateauth/nsHttpNegotiateAuth.cpp;
/cvsroot/mozilla/extensions/negotiateauth/nsHttpNegotiateAuth.cpp,v  <-- 
nsHttpNegotiateAuth.cpp
new revision: 1.5; previous revision: 1.4
done


(oops... must've marked this fixed accidentally)
You need to log in before you can comment on or make changes to this bug.