Closed Bug 286990 Opened 19 years ago Closed 19 years ago

nsHttpNegotiateAuth.cpp behaves different in debug/non-debug

Categories

(Core :: Networking: HTTP, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.8beta2

People

(Reporter: Biesinger, Assigned: Biesinger)

References

()

Details

Attachments

(1 file)

near line 219:
#ifdef DEBUG
    PRBool isGssapiAuth =
        !PL_strncasecmp(challenge, kNegotiate, kNegotiateLen);
    NS_ENSURE_TRUE(isGssapiAuth, NS_ERROR_UNEXPECTED);
#endif

So, that NS_ENSURE_TRUE will be done in debug builds only, so those builds will
behave differently... maybe this should just be an assertion?
sure.. want to cut a patch?
Attached patch patchSplinter Review
sure... why not :)
Assignee: darin → cbiesinger
Status: NEW → ASSIGNED
Attachment #178154 - Flags: superreview?(darin)
Attachment #178154 - Flags: review?(darin)
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta2
Attachment #178154 - Flags: superreview?(darin)
Attachment #178154 - Flags: superreview+
Attachment #178154 - Flags: review?(darin)
Attachment #178154 - Flags: review+
Checking in extensions/negotiateauth/nsHttpNegotiateAuth.cpp;
/cvsroot/mozilla/extensions/negotiateauth/nsHttpNegotiateAuth.cpp,v  <-- 
nsHttpNegotiateAuth.cpp
new revision: 1.5; previous revision: 1.4
done


(oops... must've marked this fixed accidentally)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: