1.22 KB, patch
|Details | Diff | Splinter Review|
The function getColorPref in PreferenceManager.mm and PreferencePaneBase.mm returns success even if the supplied value is not a valid colorstring. It should fail both if it can't get the pref and when the pref has an invalid value. See bug 286516 for an example.
Created attachment 178140 [details] [diff] [review] Make getColorPref tell if it gets an invalid value getColorPref now returns false if the value is missing, not a string, or an invalid value. Tested together with the patch for bug 286516.
Assignee: pinkerton → torben
Status: NEW → ASSIGNED
I checked in the patch. Thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Shouldn't returnColor just be set to nil on failure? This is what Apple's methods do.
Comment on attachment 178140 [details] [diff] [review] Make getColorPref tell if it gets an invalid value Clearing the review flag since smfr checked this in last month :-)
You need to log in before you can comment on or make changes to this bug.