Closed
Bug 287136
Opened 21 years ago
Closed 20 years ago
Missing validations in editproducts.cgi
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.20
People
(Reporter: LpSolit, Assigned: LpSolit)
Details
(Whiteboard: [wanted for 2.20])
Attachments
(1 file)
|
1.12 KB,
patch
|
bugreport
:
review+
|
Details | Diff | Splinter Review |
When creating a new product, editproducts.cgi does not check if the
classification given by the user actually exists or not. This way, an invalid
classification ID (0) is stored in the DB and sanitycheck.cgi then complains:
Checking references to classifications.id
... from products.classification_id
Bad value 0 found in products.classification_id
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
Flags: blocking2.20?
Target Milestone: --- → Bugzilla 2.20
|
||
Updated•21 years ago
|
Flags: blocking2.20? → blocking2.20+
|
||
Comment 1•20 years ago
|
||
"If it's not a regression from 2.18 and it's not a critical problem with
something that's already landed, let's push it off." - Dave
Flags: blocking2.20+
|
|
||
Updated•20 years ago
|
Whiteboard: [wanted for 2.20]
|
|
||
Updated•20 years ago
|
Flags: blocking2.20-
|
|
Assignee | |
Comment 2•20 years ago
|
||
Ensure the classification exists.
Attachment #181927 -
Flags: review?(wurblzap)
|
|
||
Comment 3•20 years ago
|
||
Comment on attachment 181927 [details] [diff] [review]
patch, v1
r=joel if you've tested it
Attachment #181927 -
Flags: review?(wurblzap) → review+
|
|
||
Updated•20 years ago
|
Flags: approval? → approval+
|
|
Assignee | |
Comment 5•20 years ago
|
||
Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v <-- editproducts.cgi
new revision: 1.82; previous revision: 1.81
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•