Closed Bug 287136 Opened 19 years ago Closed 19 years ago

Missing validations in editproducts.cgi

Categories

(Bugzilla :: Administration, task)

Product:
Bugzilla
Component:
Administration
Version:
2.19.2
Type:
task
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.20

People

(Reporter: LpSolit, Assigned: LpSolit)

Details

(Whiteboard: [wanted for 2.20])

Attachments

(1 file)

patch, v1
1.12 KB, patch
bugreport
: review+
Details | Diff | Splinter Review 
When creating a new product, editproducts.cgi does not check if the
classification given by the user actually exists or not. This way, an invalid
classification ID (0) is stored in the DB and sanitycheck.cgi then complains:

Checking references to classifications.id

... from products.classification_id

Bad value 0 found in products.classification_id
Status: NEW → ASSIGNED
Flags: blocking2.20?
Target Milestone: --- → Bugzilla 2.20
No longer blocks: 286294
Flags: blocking2.20? → blocking2.20+
"If it's not a regression from 2.18 and it's not a critical problem with
something that's already landed, let's push it off." - Dave
Flags: blocking2.20+
Whiteboard: [wanted for 2.20]
Flags: blocking2.20-
Attached patch patch, v1 — — Splinter Review 
Ensure the classification exists.
Attachment #181927 - Flags: review?(wurblzap)
Comment on attachment 181927 [details] [diff] [review]
patch, v1

r=joel if you've tested it
Attachment #181927 - Flags: review?(wurblzap) → review+
yes I did
Flags: approval?
Flags: approval? → approval+
Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.82; previous revision: 1.81
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: