287197 - comment formatting of os_Linux_ia64.s doesn't work with gcc 3.3.x

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P1)

Description

[Wolfgang Rosenauer [:wolfiR]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.8b2) Gecko/20050308
Build Identifier: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.8b2) Gecko/20050308

comments in os_Linux_ia64.s were changed  a few weeks ago. The change breaks
builds on gcc 3.3.x. Is the change needed for gcc 4? 

Reproducible: Always

Steps to Reproduce:
.

Actual Results:  
os_Linux_ia64.s:41: Error: junk at end of line, first unrecognized character is `/'

Comment 1

[Wan-Teh Chang]

Sorry, that was unintentional and had nothing to do
with gcc 4.  I was trying to make os_Linux_ia64.s look
similar to os_Linux_x86.s.

This means comments must begin with double slash (//)
for ia64 must may begin with a single slash (/) for
x86.  This difference is strange.

Comment 2

[Wan-Teh Chang]

Attachment: Proposed patch

This patch changes / back to //.  Could you please test this patch?

Comment 3

[Wolfgang Rosenauer [:wolfiR]]

now it build again on IA64. IMHO you can check it in. Thanks

Comment 4

[Wan-Teh Chang]

Fix checked in on the nspr tip and client branch.