287215 - EmbedContentListener.cpp does not compile as of Feb 28

Status: RESOLVED EXPIRED

(Core Graveyard :: Ports: Qt, defect)

Description

[Soeren Fietzke]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; Q312461; .NET CLR 1.1.4322)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050322

The 1.4 change (to fix Bug 283125) to 
mozilla/embedding/browser/qt/src/EmbedContentListener.cpp causes the build to 
break due to the access of the unknown class QGeckoEmbedPrivate in line 122. Or 
I am doing something terribly wrong...

Reproducible: Always

Steps to Reproduce:
1. download the SeaMonkey snapshot code from 21 March 2005
2. set ~/.mozconfig to build the suite with toolkit qt
3. cd embedding/browser/qt/src; make

Actual Results:  
EmbedContentListener.cpp: In member function `virtual nsresult 
EmbedContentListener::CanHandleContent(const char*, int, char**, PRBool*)':
EmbedContentListener.cpp:122: invalid use of undefined type `struct 
QGeckoEmbedPrivate'
qgeckoembed.h:67: forward declaration of `struct QGeckoEmbedPrivate'

Comment 1

[Soeren Fietzke]

Attachment: load QGeckoEmbedPrivate definition before use

move QGeckoEmbedPrivate class declaration in separate header file;
include qgeckoembedprivate.h in EmbedContentListener.cpp;
add include guard to EmbedStream.h

Comment 2

[Soeren Fietzke]

Attachment: declaration for class QGeckoEmbedPrivate

Comment 3

[Zack Rusin]

In general looks cool. If you could remove the commented out headers and move
the inclusion of the geckoprivate after local headers (top of the file) I'd
commit it as it is (of course, if you have an account you can commit yourself :) )

Comment 4

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 5

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.