287290 - static overruns detected by Coverity tool

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is a patch for a bunch of static overruns found by the Coverity tool.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Note that this patch removes a file in intl that's currently unused from the
build (but doesn't cvs remove it), but also syncs it up with
extensions/spellcheck.  I should file a separate bug on that...

Comment 3

[Brendan Eich [:brendan]]

Cc'ing others who might care about code patched here.

/be

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 178292 [details] [diff] [review]
patch

r+sr=me.

/be

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk.  Filed unused intl code as bug 287340.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(I didn't check in the Makefile.in change, but left that to the new bug.)

Comment 7

[Axel Hecht]

This will merge conflict with bug 283089.
I'll CC dbaron on the parent bug 283681, to avoid further conflicts.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: fix OOM case too, and sync GTK2

Comment 9

[Brendan Eich [:brendan]]

Comment on attachment 178604 [details] [diff] [review]
fix OOM case too, and sync GTK2

r+sr=me.

/be

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

followup checked in