Closed Bug 287290 Opened 15 years ago Closed 15 years ago

static overruns detected by Coverity tool

Categories

(Core :: Widget: Gtk, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla1.8beta2

People

(Reporter: dbaron, Assigned: dbaron)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [patch])

Attachments

(2 files)

This is a patch for a bunch of static overruns found by the Coverity tool.
Assignee: nobody → dbaron
Attached patch patchSplinter Review
Attachment #178292 - Flags: superreview?(brendan)
Attachment #178292 - Flags: review?(brendan)
Note that this patch removes a file in intl that's currently unused from the
build (but doesn't cvs remove it), but also syncs it up with
extensions/spellcheck.  I should file a separate bug on that...
Cc'ing others who might care about code patched here.

/be
Comment on attachment 178292 [details] [diff] [review]
patch

r+sr=me.

/be
Attachment #178292 - Flags: superreview?(brendan)
Attachment #178292 - Flags: superreview+
Attachment #178292 - Flags: review?(brendan)
Attachment #178292 - Flags: review+
Priority: -- → P1
Whiteboard: [patch]
Target Milestone: --- → mozilla1.8beta2
Fix checked in to trunk.  Filed unused intl code as bug 287340.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
(I didn't check in the Makefile.in change, but left that to the new bug.)
This will merge conflict with bug 283089.
I'll CC dbaron on the parent bug 283681, to avoid further conflicts.
Attachment #178604 - Flags: superreview?(brendan)
Attachment #178604 - Flags: review?(brendan)
Comment on attachment 178604 [details] [diff] [review]
fix OOM case too, and sync GTK2

r+sr=me.

/be
Attachment #178604 - Flags: superreview?(brendan)
Attachment #178604 - Flags: superreview+
Attachment #178604 - Flags: review?(brendan)
Attachment #178604 - Flags: review+
followup checked in
Keywords: coverity
Component: XP Miscellany → Widget: Gtk
You need to log in before you can comment on or make changes to this bug.