Closed
Bug 287340
Opened 19 years ago
Closed 19 years ago
unused code in intl/unichartutil/src/
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: jshin1987)
References
Details
Attachments
(1 file)
4.38 KB,
patch
|
smontagu
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
The following files in intl/unicharutil/src/ appear to be completely unused and could be removed if they're removed from the Makefile.in: cattable.h nsCategoryImp.cpp nsCategoryImp.h The first includes a significant amount of static data. However, extensions/spellcheck has a forked copy of the first file (which I just synchronized as part of bug 287290). We definitely shouldn't carry around a lot of static data that we don't need, but we may want to have the code in intl rather than extensions (I'm not sure).
Comment 1•19 years ago
|
||
I didn't know about the forked copy. I would rather have one copy of this in intl (and update it regularly!), unless it's a problem for spellcheck to depend on intl.
Assignee | ||
Comment 2•19 years ago
|
||
I guess spellchecker is bound to depend on intl unless it wants to have its own 'mini intl' so that keeping 'the' single copy in intl should be fine. Related is bug 210502
Assignee | ||
Comment 3•19 years ago
|
||
For now, I took an easier path (option #1 in bug 210502 comment #17). In the long run, we'd better take option #2 in the comment. Btw, I'll also cvs-remove cattable.h in spellcheck.
Assignee: smontagu → jshin1987
Status: NEW → ASSIGNED
Attachment #179706 -
Flags: superreview?(dbaron)
Attachment #179706 -
Flags: review?(smontagu)
Updated•19 years ago
|
Attachment #179706 -
Flags: review?(smontagu) → review+
Reporter | ||
Updated•19 years ago
|
Attachment #179706 -
Flags: superreview?(dbaron) → superreview+
Assignee | ||
Comment 4•19 years ago
|
||
thanks for r/sr. I'll land the patch as soon as I get r/sr for attachment 179704 [details] [diff] [review] (bug 210502)
Depends on: 210502
Assignee | ||
Comment 5•19 years ago
|
||
thanks for r/sr. the patch got landed. I'll resolve this as fixed and open a new bug so that spellcheck can access the category code via xpcom.
Assignee | ||
Comment 6•19 years ago
|
||
sorry for bug spam
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•19 years ago
|
||
Just for the record, there are at least two potential consumers of this interface (other than spell checker), one of which is wallet (bug 282111). I came across the other a couple of weeks ago (it's already in bugzilla), but forgot which.
You need to log in
before you can comment on or make changes to this bug.
Description
•