287340 - unused code in intl/unichartutil/src/

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The following files in intl/unicharutil/src/ appear to be completely unused and
could be removed if they're removed from the Makefile.in:
  cattable.h
  nsCategoryImp.cpp
  nsCategoryImp.h

The first includes a significant amount of static data.

However, extensions/spellcheck has a forked copy of the first file (which I just
synchronized as part of bug 287290).

We definitely shouldn't carry around a lot of static data that we don't need,
but we may want to have the code in intl rather than extensions (I'm not sure).

Comment 1

[Simon Montagu :smontagu]

I didn't know about the forked copy. I would rather have one copy of this in
intl (and update it regularly!), unless it's a problem for spellcheck to depend
on intl.

Comment 2

[Jungshik Shin]

I guess spellchecker is bound to depend on intl unless it wants to have its own
'mini intl' so that keeping 'the' single copy in intl should be fine. Related is
bug 210502

Comment 3

[Jungshik Shin]

Attachment: patch

For now, I took an easier path (option #1 in bug 210502 comment #17). In the
long run, we'd better take option #2 in the comment. 
Btw, I'll also cvs-remove cattable.h in spellcheck.

Comment 4

[Jungshik Shin]

thanks for r/sr. I'll land the patch as soon as I get r/sr for attachment 179704 [details] [diff] [review]
(bug 210502)

Comment 5

[Jungshik Shin]

thanks for r/sr.
the patch got landed. I'll resolve this as fixed and open a new bug so that
spellcheck can access the category code via xpcom.

Comment 6

[Jungshik Shin]

sorry for bug spam

Comment 7

[Jungshik Shin]

Just for the record, there are at least two potential consumers of this
interface (other than spell checker), one of which is wallet (bug 282111). I
came across the other a couple of weeks ago (it's already in bugzilla), but
forgot which.