287388 - nsBidi.cpp won't build on Solaris 10 x86 due to macros "ES" and "CS" being used

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Brett Albertson]

User-Agent:       Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.7) Gecko/20041221
Build Identifier: 

When compiling Mozilla 1.8B1 or Firefox 1.0.1 I get the following on Solaris 10 x86:

gmake[1]: Entering directory `/var/tmp/mozilla/layout/base/src'
nsBidi.cpp
c++ -o nsBidi.o -c -DOSTYPE=\"SunOS5\" -DOSARCH=\"SunOS\" -D_IMPL_NS_LAYOUT
-I../../../content/events/src -I./../../html/base/src -I./../../html/style/src
-I./../../xul/base/src -I./../../xul/content/src  -I../../../dist/include/xpcom
-I../../../dist/include/string -I../../../dist/include/dom
-I../../../dist/include/content -I../../../dist/include/gfx
-I../../../dist/include/widget -I../../../dist/include/view
-I../../../dist/include/locale -I../../../dist/include/webshell
-I../../../dist/include/necko -I../../../dist/include/uconv
-I../../../dist/include/pref -I../../../dist/include/uriloader
-I../../../dist/include/docshell -I../../../dist/include/imglib2
-I../../../dist/include/layout -I../../../dist/include
-I/var/tmp/mozilla/dist/include/nspr     -I/usr/openwin/include    
-I/usr/openwin/include -fno-rtti -fno-exceptions -Wno-long-long -pedantic -O2
-fshort-wchar -pthreads -pipe  -DNDEBUG -DTRIMMED -O3  -I/usr/openwin/include
-DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/nsBidi.pp
nsBidi.cpp
nsBidi.cpp:69: error: expected identifier before numeric constant
nsBidi.cpp:69: error: expected `}' before numeric constant
nsBidi.cpp:69: error: expected unqualified-id before numeric constant
nsBidi.cpp:69: error: expected `,' or `;' before numeric constant
nsBidi.cpp:86: error: expected declaration before '}' token
nsBidi.cpp:27:1: unterminated #ifdef
gmake[1]: *** [nsBidi.o] Error 1
gmake[1]: Leaving directory `/var/tmp/mozilla/layout/base/src'
gmake: *** [all] Error 2


Reproducible: Always

Steps to Reproduce:
1. Download the source code for Firefox 1.0.1 or Mozilla 1.8B1
2. Compile following the directions
3. The above error appears



Expected Results:  
Compile successfully

Comment 1

[Brett Albertson]

Attachment: nsBidi.cpp patch for Solaris 10 x86

Comment 2

[Brett Albertson]

"ES" and "CS" can be changed to anything, I just picked "ES2" and "CS2" for
convenience.  I'm not sure why those is only a problem on this platform.

Brett

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 178367 [details] [diff] [review]
nsBidi.cpp patch for Solaris 10 x86

sr=dbaron if you use something more sensible like ENS and CNS.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

That said, if what you're overriding is a macro, you could probably fix it with
some #undefs, which would be preferable, I think.

Comment 5

[Simon Montagu :smontagu]

Won't this break the macros in nsBidi.h, e.g.
http://lxr.mozilla.org/seamonkey/source/layout/base/nsBidi.h#318 ?

Comment 6

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 7

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.

Comment 8

[Boris Zbarsky [:bzbarsky]]

OK.  This bug has a patch.  And partial reviews.  Why was it EVER included in
this auto-expire game?

Comment 9

[Boris Zbarsky [:bzbarsky]]

Simon, if this is r-, please mark so.  But then we still need to fix the
compilation issue.

Comment 10

[Simon Montagu :smontagu]

Comment on attachment 178367 [details] [diff] [review]
nsBidi.cpp patch for Solaris 10 x86

I agree with comment 4.

Comment 11

[Joubert Nel]

Hi -

In the latest source code download of XULRunner I see that a patch has not been applied yet. Hence, when compiling on Solaris 10 (x86) it is necessary to manually edit nsBidi.cpp.

Any chance that the patch will get applied?

Thanks
Joubert

Comment 12

[Simon Montagu :smontagu]

Attachment: Testcase regressed by attachment 178367

This patch is certainly not going to get applied. Here is a testcase that it regresses, as I anticipated. Since nobody else has suggested an alternative patch, I'll make one myself.

Comment 13

[Simon Montagu :smontagu]

Attachment: Alternative patch using #undef

Joubert, can you confirm that this patch fixes the build errors on Solaris?

Comment 14

[Joubert Nel]

(In reply to comment #13)
> Created an attachment (id=253070) [details]
> Alternative patch using #undef
> 
> Joubert, can you confirm that this patch fixes the build errors on Solaris?
> 

Hi Simon, this patch works perfectly.

Thanks for your time.

Comment 15

[Simon Montagu :smontagu]

Checked in