287428 - libxul builds horked when the initial build target is "alldep"

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Benjamin Smedberg]

The root Makefile.in has several different build paths, and the "tiered" build
path for libxul is being skipped by the "alldep" build target. This is almost
certainly what's making the sweetlou tbox red.

Comment 1

[Darin Fisher]

The neptune xulrunner tinderbox is using a very old version of the tinderbox
build scripts, which appears to explain why it is not using build_all_depend as
its target and thus why it is not experiencing this problem.

Comment 2

[Benjamin Smedberg]

Attachment: Suppress default "alldep" and "all" targets

Comment 3

[Darin Fisher]

Comment on attachment 178404 [details] [diff] [review]
Suppress default "alldep" and "all" targets

r=darin

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 178404 [details] [diff] [review]
Suppress default "alldep" and "all" targets

one of your modifications is in half of an if/else, and you don't touch the
other half.  (See the other "default:" target for the other half.)  I suspect
the answer there may be to move your second change inside the ifeq.

Also, is this really the right thing for alldep?  To the tiers do depend?

Comment 5

[Benjamin Smedberg]

Attachment: Suppress default "alldep" and "all" targets, rev. 1.1

Good catch, I have moved the suppress var into the ifdef. I don't think that
the depend rules are necessary: we make depend as part of the libs target now,
and the depend rule is a dummy, as far as I understand rules.mk.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 179058 [details] [diff] [review]
Suppress default "alldep" and "all" targets, rev. 1.1

>-default: $(SUBMAKEFILES)
>+default:: $(SUBMAKEFILES)
> 	$(MAKE) export
> 	$(MAKE) libs

Should this rule still be here?  And does changing : to :: make it do something
now?  r=dbaron if you've tested that this doesn't make us do two passes over
the tree.

Comment 7

[Benjamin Smedberg]

Fixed on trunk