Closed
Bug 287439
Opened 20 years ago
Closed 20 years ago
Don't copy the pop3 password pref when migrating from netscape 4.x
Categories
(MailNews Core :: Profile Migration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mscott, Assigned: mscott)
Details
Attachments
(1 file)
|
1.94 KB,
patch
|
dveditz
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
When we migrate a profile from netscape 4.x, we copy over the pref:
mail.pop_password
we should just clear this pref instead since we don't use it.
|
Assignee | |
Comment 1•20 years ago
|
||
m_prefs can't be null here.
we ignore the return value because ClearPref throws an error if the pref does
not exist.
I also removed some dead code inside of a CAN_UPGRADE_4x_PASSWORDS ifdef.
Attachment #178405 -
Flags: superreview?(bienvenu)
Attachment #178405 -
Flags: review?(dveditz)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 178405 [details] [diff] [review]
the fix
+ m_prefs->ClearUserPref(PREF_4X_MAIL_POP_PASSWORD); // intentionally ignore
the return value
you could just say (void) m_prefs->Clear... which carries the same meaning
*and* silences any compiler warnings :-)
Attachment #178405 -
Flags: superreview?(bienvenu) → superreview+
|
||
Comment 3•20 years ago
|
||
Comment on attachment 178405 [details] [diff] [review]
the fix
r=dveditz (what David said)
Attachment #178405 -
Flags: review?(dveditz) → review+
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•