Closed Bug 287506 Opened 20 years ago Closed 18 years ago

increase the size of lxr text input fields

Categories

(Webtools Graveyard :: MXR, enhancement)

Product:
Webtools Graveyard
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

References

(
URL
)

Details

Attachments

(2 files, 1 obsolete file)

how's this?
4.47 KB, text/html
Details
also fix the rest of the validation errors
3.92 KB, patch
timeless
: review-
Details | Diff | Splinter Review
Search for the file contentAreaUtils.js, then contentAreaCommands.properties. Then search again for contentAreaUtils.js by entering "cont" in the file search input field. Firefox offers "contentAre...", and "contentAre...". Firefox would display the full file name if the text input field was wider. So let's please increase the size of the fields.
if you follow links to http://lxr.mozilla.org/seamonkey/search http://lxr.mozilla.org/seamonkey/find we give you more space, this was clearly a design decision, favoring the right content. you have quick access to search/find/ident, but not lots of space wasted on the field. partly it seems like firefox's ui is behaving foolishly.
Just change size="8" to e.g. 20. That doesn't incredibly hurt the layout, but makes the page much more useable. After all, how often do you read the text at the right side, if you read it at all, compared to how often you use the search boxes?
personally i use bookmark keywords ... it's possible i've read the right side more than i've used the left, but that's partly because i've rewritten the right side at times. in terms of space, how does the current layout compare to the number of characters in your browser's web search input field?
(In reply to comment #3) > personally i use bookmark keywords ... That's a workaround. But Firefox doesn't offer autocomplete after you hit space in the url bar. That's another bug though. > it's possible i've read the right side more than i've used the left, but that's > partly because i've rewritten the right side at times. :) > in terms of space, how does the current layout compare to the number of > characters in your browser's web search input field? That's about 11 times as large, which shows that these text fields are far too narrow. ;-)
erm. maybe i wasn't clear. <- -> () X ^h [// http://www.mozilla.org ... v] (> Go [Gv 0123456789abcdef] ^^^^^^^^^^^^^^^^ that's ff1.0
This could also fix bug 95691.
Assignee: chase → steffen.wilberg
Blocks: 95691
OS: Linux → All
Hardware: PC → All
Attached file how's this? —
Timeless asked me to make the text fields as large as lxr permits for searches, which is 29 characters. I moved the labels above the text fields to save some space. This also fixes the 3 wrapping bugs.
Attached patch patch (obsolete) — — Splinter Review
Someone should remove all these nested tables, but that's another bug. And someone should untabbify this document.
Attachment #178473 - Flags: review?(timeless)
Makes the document almost valid HTML 4.01 Transitional, and adds a doctype so we render in standards compliance mode. The remaining problems are the <WBR> tags, which can be replaced (including the hyphen) by &shy; once bug 9101 is fixed.
Attachment #178473 - Attachment is obsolete: true
Attachment #178475 - Flags: review?(timeless)
Attachment #178473 - Flags: review?(timeless)
Er, remove the doctype. Rendering in standards compliance mode makes the page look different in a number of places. I don't want to compensate that right now.
Comment on attachment 178475 [details] [diff] [review] also fix the rest of the validation errors >Index: mozilla/webtools/lxr/index.html >=================================================================== >RCS file: /cvsroot/mozilla/webtools/lxr/index.html,v >retrieving revision 1.12 >diff -u -8 -r1.12 index.html >--- mozilla/webtools/lxr/index.html 27 Aug 2002 03:34:28 -0000 1.12 >+++ mozilla/webtools/lxr/index.html 24 Mar 2005 14:50:23 -0000 >@@ -1,8 +1,10 @@ >+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"> you said you would remove this >@@ -13,101 +15,90 @@ >- <INPUT TYPE=TEXT NAME="string" VALUE="" SIZE=8> >+ <LABEL for="text"><A HREF="search"><B>Text Search:</B></A></LABEL><BR> this is bad, labels are essentially links, which means you're asking a text node to have two competing actions (load a different page, set focus to an input) >+ <INPUT ID="text" TYPE=TEXT NAME="string" VALUE="" SIZE=29><BR> (that's a general problem, please rework).
Attachment #178475 - Flags: review?(timeless) → review-
QA Contact: timeless → lxr
This is fixed with http://mxr.mozilla.org/seamonkey/. Is there a somehow-fixed-by-mxr bug to dupe this one against?
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → WORKSFORME
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: