287564 - Give the Download Manager a visibly different icon than the browser window

Status: RESOLVED INVALID

(Toolkit :: Downloads API, enhancement)

Description

[Timwi]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2 StumbleUpon/1.9993
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2 StumbleUpon/1.9993

The Download Manager should have an icon that is noticeably distinct from that
for the browser window. Especially when trying to switch to one of the windows
using Alt-Tab, it is frustrating that the icons are identical.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Timwi]

Attachment: Suggestion

A crude (unprofessionally-made) suggestion for an icon for the Download
Manager. (Made from the Firefox logo and the graphic in the top-right corner of
the download box on http://www.mozilla.org/products/firefox/).

Comment 2

[Kevin Gerich]

Something that doesn't use the Firefox logo would be best for readability, and
sidestep the need to have branded and unbranded versions. The app icon is
complex enough without another element (arrow) on it, especially at 16px.

See also bug 226599. Ideally we should have distinct icons for Extensions,
Themes, Bookmark Manager, JS Console, etc.

We should probably use the Winstripe download toolbar icon for now, though it
would be nice if other themes could specify their own window icons.

Comment 3

[Mike Connor [:mconnor]]

Yeah, that works.  Kevin, can you do this?  Or just attach the images in the
right format and I will?

Comment 4

[Kevin Gerich]

I'll take a crack at it this weekend. I'll bug you if I need help :)

..should this be OS=All? It would be nice to have for GTK builds too

Comment 5

[Mike Connor [:mconnor]]

Yes, all platforms should have this.

Comment 6

[Kevin Gerich]

Attachment: patch to add the icons

Here's the patch. I'll attach my first try at the XPM files. They still need a
bit of cleanup, and I need to create the Windows and OS2 ico files. 

cvs diff: Diffing browser/app/icons
cvs diff: Diffing browser/app/icons/gtk
cvs diff: browser/app/icons/gtk/downloadManager.xpm is a new entry, no
comparison available
cvs diff: browser/app/icons/gtk/downloadManager16.xpm is a new entry, no
comparison available
cvs diff: Diffing browser/app/icons/os2
cvs diff: Diffing browser/app/icons/windows

Comment 7

[Kevin Gerich]

Attachment: 16px downloadManager XPM

Comment 8

[Kevin Gerich]

Attachment: 48px downloadManager XPM

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 178677 [details] [diff] [review]
patch to add the icons

hmm, this is really a spinoff/dupe of Bug 226599, but lets fix this, for now.

and actually bug 242050 covers the same territory for *nix.  But I'd rather
handle it step by step, or there's too much noise.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:mak, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 12

[Marco Bonardo [:mak]]

doesn't apply to current Firefox since there's no separate download manager and the Library is a comprehensive ui not just dedicated to downloads.