287570 - [Windows, VcToolkit2003] Fix: "LINK : warning LNK4044: unrecognized option '/L{...}'; ignored"

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Serge Gautherie (:sgautherie)]

"Self-Compiled [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b)
Gecko/20050324] (<-- v1.8b1 !) (W2Ksp4)"

I get a few warnings like this one
{{
/cygdrive/d/mozbuild/mozilla/build/cygwin-wrapper link /NOLOGO /OUT:mozilla.exe
/PDB:mozilla.pdb /SUBSYSTEM:WINDOWS    /HEAP:0x40000 nsAppRunner.obj
showOSAlert.obj nsStaticComponents.obj nsNativeAppSupportWin.obj
nsNativeAppSupportBase.obj ./module.res -L../../dist/lib/components  
../../dist/lib/xpcom.lib ../../dist/lib/xpcom_core.lib ../../dist/lib/js3250.lib
../../dist/lib/nspr4.lib ../../dist/lib/plc4.lib ../../dist/lib/plds4.lib  
../../dist/lib/components/xpcom_compat_c.lib
../../dist/lib/components/xpc3250.lib ../../dist/lib/components/uconv.lib
../../dist/lib/components/i18n.lib ../../dist/lib/components/intlcmpt.lib
../../dist/lib/components/ipcdc.lib ../../dist/lib/components/necko.lib
../../dist/lib/components/necko2.lib ../../dist/lib/components/xppref32.lib
../../dist/lib/components/caps.lib ../../dist/lib/components/rdf.lib
../../dist/lib/components/gkparser.lib ../../dist/lib/components/gkgfxwin.lib
../../dist/lib/components/imgicon.lib ../../dist/lib/components/imglib2.lib
../../dist/lib/components/gkplugin.lib ../../dist/lib/components/gkwidget.lib
../../dist/lib/components/gklayout.lib ../../dist/lib/components/docshell.lib
../../dist/lib/components/embedcomponents.lib
../../dist/lib/components/webbrwsr.lib ../../dist/lib/components/editor.lib
../../dist/lib/components/txmgr.lib ../../dist/lib/components/composer.lib
../../dist/lib/components/appshell.lib ../../dist/lib/components/oji.lib
../../dist/lib/components/chrome.lib ../../dist/lib/components/profile.lib
../../dist/lib/components/nsprefm.lib ../../dist/lib/components/mork.lib
../../dist/lib/components/mozfind.lib ../../dist/lib/components/appcomps.lib
../../dist/lib/components/cookie.lib ../../dist/lib/components/wallet.lib
../../dist/lib/components/wlltvwrs.lib ../../dist/lib/components/xmlextras.lib
../../dist/lib/components/p3p.lib ../../dist/lib/components/autoconfig.lib
../../dist/lib/components/transformiix.lib
../../dist/lib/components/universalchardet.lib
../../dist/lib/components/typeaheadfind.lib
../../dist/lib/components/websrvcs.lib
../../dist/lib/components/negotiateauth.lib ../../dist/lib/components/perms.lib
../../dist/lib/unicharutil_s.lib ../../dist/lib/ucvutil_s.lib
../../dist/lib/gfxshared_s.lib ../../dist/lib/gkgfx.lib
../../dist/lib/jsj3250.lib  ../../dist/lib/png.lib ../../dist/lib/jpeg3250.lib
../../dist/lib/mozz.lib  ../../dist/lib/xpcom_compat.lib comctl32.lib
comdlg32.lib uuid.lib shell32.lib ole32.lib oleaut32.lib Urlmon.lib version.lib
winspool.lib kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib
advapi32.lib comctl32.lib comdlg32.lib uuid.lib shell32.lib ole32.lib
oleaut32.lib version.lib winspool.lib gdi32.lib

LINK : warning LNK4044: unrecognized option '/L../../dist/lib/components'; ignored
}}

I'm using
{{
Microsoft (R) Incremental Linker Version 7.10.3077
Copyright (C) Microsoft Corporation.  All rights reserved.
}}

I guess it expects
{{
/LIBPATH:dir
}}
!?

My build (with the options I used) seems to be runnig well: I don't know how to
check if this warning has some bad side-effects or not...

Comment 1

[cls]

Attachment: (Av1) <xpfe/bootstrap> [Checked in: Comment 10]

It's just a warning.  There are no ill-effects because the -L option is ignored
by msvc.  This patch should silence the warning for msvc-like builds.

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> It's just a warning.  There are no ill-effects because the -L option is ignored
> by msvc.  This patch should silence the warning for msvc-like builds.

"Self-Compiled [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b)
Gecko/20050324] (<-- v1.8b1 !) (W2Ksp4)"

This patch does silence the warning on my build :-)

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) <extensions/spellcheck/myspell/src>

"Self-Compiled [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b)
Gecko/20050324] (<-- v1.8b1 !) (W2Ksp4)"

Fixes (the two other warnings which I got)
{{
/cygdrive/d/mozbuild/mozilla/build/cygwin-wrapper link /NOLOGO /DLL
/OUT:myspell.dll /PDB:myspell.pdb /SUBSYSTEM:WINDOWS  affentry.obj affixmgr.obj
hashmgr.obj suggestmgr.obj csutil.obj myspell.obj mozMySpell.obj
mozMySpellFactory.obj	./module.res	-L../../../../dist/bin
-L../../../../dist/lib ../../../../dist/lib/xpcom.lib
../../../../dist/lib/xpcom_core.lib ../../../../dist/lib/nspr4.lib
../../../../dist/lib/plc4.lib ../../../../dist/lib/plds4.lib 
../../../../dist/lib/unicharutil_s.lib	 kernel32.lib user32.lib gdi32.lib
winmm.lib wsock32.lib advapi32.lib
LINK : warning LNK4044: unrecognized option '/L../../../../dist/bin'; ignored
LINK : warning LNK4044: unrecognized option '/L../../../../dist/lib'; ignored
}}

Comment 4

[cls]

Comment on attachment 180083 [details] [diff] [review]
(Bv1) <extensions/spellcheck/myspell/src>

They should be using the LIBS_DIR macro there instead of hardcoding the -L
paths.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 179915 [details] [diff] [review]
(Av1) <xpfe/bootstrap>
[Checked in: Comment 10]

Then, would you want to fix the other files too ?
{{
<http://lxr.mozilla.org/mozilla/search?string=-L%24%28DIST%29%2Flib%2Fcomponent
s>

-L$(DIST)/lib/components

/browser/app/Makefile.in, line 73 -- STATIC_COMPONENTS_LINKER_PATH =
-L$(DIST)/lib/components
/calendar/sunbird/app/Makefile.in, line 73 -- STATIC_COMPONENTS_LINKER_PATH =
-L$(DIST)/lib/components
/config/static-config.mk, line 56 -- STATIC_EXTRA_LIBS +=
-L$(DIST)/lib/components
/mail/app/Makefile.in, line 72 -- STATIC_COMPONENTS_LINKER_PATH =
-L$(DIST)/lib/components
/xpfe/bootstrap/Makefile.in, line 149 -- STATIC_COMPONENTS_LINKER_PATH =
-L$(DIST)/lib/components
/xulrunner/app/Makefile.in, line 85 -- STATIC_COMPONENTS_LINKER_PATH =
-L$(DIST)/lib/components
}}

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Bv2) <extensions/spellcheck/myspell/src> [Checked in: Comment 8]

"Self-Compiled [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b)
Gecko/20050324] (<-- v1.8b1 !) (W2Ksp4)"

Bv1, with comment 4 suggestion.

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 180359 [details] [diff] [review]
(Bv2) <extensions/spellcheck/myspell/src>
[Checked in: Comment 8]

'approval1.8b3=?':
Trivial make code cleanup, no risk.

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 180359 [details] [diff] [review]
(Bv2) <extensions/spellcheck/myspell/src>
[Checked in: Comment 8]


Check in: { 2005-06-08 01:07	neil%parkwaycc.co.uk	mozilla/ extensions/
spellcheck/ myspell/ src/ Makefile.in	   1.11 }

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 179915 [details] [diff] [review]
(Av1) <xpfe/bootstrap>
[Checked in: Comment 10]

'approval1.8b3=?':
Trivial make code cleanup, no risk.

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 179915 [details] [diff] [review]
(Av1) <xpfe/bootstrap>
[Checked in: Comment 10]


Check in: { 2005-06-09 01:54	neil%parkwaycc.co.uk	mozilla/ xpfe/
bootstrap/ Makefile.in	 1.279 }

Comment 11

[Philip Chee]

The remaining TODOs don't affect SeaMonkey which is the product this bug is in.