287688 - "Bookmarks" item has inconsistent text layout during customizing

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[Prakash Mehrotra]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050323 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050323 Firefox/1.0+

The text "Bookmarks Toolbar Items" associated with the "Bookmarks" item gets
different alignment depending on whether it has been dragged from the 'Customize
toolbar' dialog or not. The attachment shows this very clearly.

Reproducible: Always

Comment 1

[Prakash Mehrotra]

Attachment: Screesnhots showing the alignment inconsistency

Comment 2

[Daniel C]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050324 Firefox/1.0+

(In reply to comment #0)

WFM - I get the text left-aligned in both instances.

Comment 3

[Prakash Mehrotra]

Confirmed under version 1.02, text is left aligned in both instances. I get this
problem in Gecko/20050323 which was a nightly build. 

Developers need to confirm that this bug has not been introduced in versions
after 1.02 which are still under developement.

Comment 4

[Takeshi Nishimura]

Tested on trunk-20050316.

This seems to have connection with the item's usual size. That is:
If you have enough bookmarks to fill in Bookmarks Toolbar Folder, it certainly
*is* center-aligned.
If you have no bookmarks in Bookmarks Toolbar Folder, it looks like left-aligned.
(Make sure you restart Firefox after you make the folder empty.)

Anyway, once you remove the item from toolbars and restore it, it is left-aligned.

Comment 5

[Takeshi Nishimura]

You can change this behavior by writing these to your userChrome.css:

.bookmarks-toolbar-customize {
max-width: none !important;
}

OR

.bookmarks-toolbar-customize .toolbarbutton-text {
text-align: left !important;
}

For debugging you can make the bookmark toolbar box visible.

.bookmarks-toolbar-customize {
border: solid 1px grey !important;
}

I think it is essential that max-width is not effective in some cases.

Comment 6

[Takeshi Nishimura]

WFM (the text is properly center-aligned) with current trunk, while 1.5 RC 2 still has this bug.

(In reply to comment #5)
The max-width problem (i.e. max-width restriction on a box in a stack
http://lxr.mozilla.org/mozilla/source/browser/themes/winstripe/browser/browser.css#113
> max-width: 15em !important;
is not effective) is described in bug 281426.

You can make max-width effective to force left-aligned. Add the following to your userChrome.css.
toolbarpaletteitem[place="toolbar"] #bookmarks-stack {
  max-width: 15em;
}
toolbarpaletteitem[place="toolbar"] .bookmarks-toolbar-overflow-items {
  display: none;
}
toolbarpaletteitem[place="toolbar"] .bookmarks-toolbar-items {
  display: none;
}

Comment 7

[Phil Ringnalda (:philor)]

Nobody's going to be going back to 1.5 to fix it there at this point, and it does indeed work in current trunk, so WFM.