287695 - Hardcoded appname in default mailto: form subject

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Robert Kaiser]

In
http://lxr.mozilla.org/mozilla/search?string=DefaultFormSubject
we use "Form Post from Mozilla" as default subject for mailto: form posts. We
should replace "Mozilla" with whatever app name we're using (brandShortName).

Very soon, we won't even have any product called "Mozilla" on the trunk any more
(see bug 285696), and it also looks strange for Firefox (see bug 265300).

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

Comment 2

[Robert Kaiser]

Comment on attachment 179006 [details] [diff] [review]
patch

OK, I built with this here (on Linux) with a different breandShortName than
"Mozilla", and it compiles and works correctly.

Comment 3

[Boris Zbarsky [:bzbarsky]]

How about adding brand.properties to the properties files that nsContentUtils
knows about instead of copying all that code?

Comment 4

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

Comment 5

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 179401 [details] [diff] [review]
patch

+					    formatStrings, 1, subjectStr);

s/1/NS_ARRAY_LENGTH(formatStrings)/

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 179401 [details] [diff] [review]
patch

sr=bzbarsky if biesi's nit is addressed.

Comment 8

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

checked in

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using LXR for code inspection:

http://lxr.mozilla.org/mozilla/search?string=DefaultFormSubject

DefaultFormSubject
/content/html/content/src/nsFormSubmission.cpp, line 460 -- "DefaultFormSubject",
/dom/locales/en-US/chrome/layout/HtmlForm.properties, line 44 -- # LOCALIZATION
NOTE (DefaultFormSubject): %S will be replaced with brandShortName
/dom/locales/en-US/chrome/layout/HtmlForm.properties, line 45 --
DefaultFormSubject=Form Post from %S