287713 - Remove hard-coded "Mozilla" in Help .rdf files

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Stefan [:stefanh]]

KaiRo have found some hard-coded Mozilla-strings in help-toc.rdf and
mozillahelp.rdf. They should be removed and replaced with the entity used in
brand.dtd.

Comment 1

[Stefan [:stefanh]]

Attachment: Replace "Mozilla" with &brandShortName; in .rdf files

Comment 2

[Doron Rosenberg (IBM)]

Comment on attachment 178583 [details] [diff] [review]
Replace "Mozilla" with &brandShortName; in .rdf files

worked fine here.

Comment 3

[Stefan [:stefanh]]

Attachment: New version with fixed comments (Checked in)

KaiRo spotted some comments with "Mozilla". I just removed Mozilla.

Comment 4

[Stefan [:stefanh]]

Comment on attachment 178592 [details] [diff] [review]
New version with fixed comments (Checked in)

Transfering doron's r to the new patch...

Comment 5

[Stefan [:stefanh]]

Comment on attachment 178583 [details] [diff] [review]
Replace "Mozilla" with &brandShortName; in .rdf files

Removing the obsolete request.

Comment 6

[Ian Neal]

Comment on attachment 178592 [details] [diff] [review]
New version with fixed comments (Checked in)

Checking in help-toc.rdf;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/help-toc.rdf,v	<-- 
help-toc.rdf
new revision: 1.73; previous revision: 1.72
done
Checking in mozillahelp.rdf;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/mozillahelp.rdf,v  <-- 
mozillahelp.rdf
new revision: 1.9; previous revision: 1.8
done

Comment 7

[Stefan [:stefanh]]

--> Fixed

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

+<!DOCTYPE RDF SYSTEM "chrome://branding/locale/brand.dtd" >
 
 <rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"

um... doesn't that need to be <!DOCTYPE rdf:RDF? (not like mozilla cares...)

Comment 9

[Stefan [:stefanh]]

Attachment: dtd-fix (Checked in)

> um... doesn't that need to be <!DOCTYPE rdf:RDF? (not like mozilla cares...)

Yeah, missed that.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/extensions/help/resources/locale/en-US&command=DIFF_FRAMESET&file=help-toc.rdf&rev1=1.72&rev2=1.73&root=/cvsroot

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/extensions/help/resources/locale/en-US&command=DIFF_FRAMESET&file=mozillahelp.rdf&rev1=1.8&rev2=1.9&root=/cvsroot

Comment 11

[Ian Neal]

Comment on attachment 178642 [details] [diff] [review]
dtd-fix (Checked in)

Checking in help-toc.rdf;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/help-toc.rdf,v	<-- 
help-toc.rdf
new revision: 1.74; previous revision: 1.73
done
Checking in mozillahelp.rdf;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/mozillahelp.rdf,v  <-- 
mozillahelp.rdf
new revision: 1.10; previous revision: 1.9
done