287714 - Add console outputting of errors.

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Doron Rosenberg (IBM)]

Comment 1

[Doron Rosenberg (IBM)]

Attachment: initial patch

Comment 2

[aaronr]

comments:

XformsUtils::ReportError():
 - Why have to clone aElement?  Why can't you serialize aElement directly
instead of using tmpNode?
 - Should we log empty strings?  I'd vote no which would require an extra test
in here.

nsXFormsUtils.h:
 - you need to add comments to the ReportError declaration.

Comment 3

[Doron Rosenberg (IBM)]

Attachment: with nits covered

Comment 4

[aaronr]

+    // if a context was defined, we clone (not deep) it, serialize it and append
+    // to the message.
+    if (aContext) {
+      nsCOMPtr<nsIDOMSerializer> ds = do_GetService(NS_XMLSERIALIZER_CONTRACTID);
+      if (ds) {
+        nsAutoString contextMsg;
+        nsCOMPtr<nsIDOMNode> tmpNode;
+        // SerializeToString always does a deep serialize, so we do a non-deep
+        // clone so that we don't serialize any children.
+        aElement->CloneNode(PR_FALSE, getter_AddRefs(tmpNode));
+

Shouldn't you be cloning aContext and not aElement?

Comment 5

[Doron Rosenberg (IBM)]

Attachment: more nit fixing

Comment 6

[Doron Rosenberg (IBM)]

Attachment: add localization

Comment 7

[Doron Rosenberg (IBM)]

Attachment: better patch

Comment 8

[Doron Rosenberg (IBM)]

Attachment: testcase

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

r=me

Comment 10

[aaronr]

Comment on attachment 178965 [details] [diff] [review]
better patch

I'd really like to see a way to log errors and warnings to the console too,
instead of just "messages".  IRC says that should just be a flag on the
nsIConsoleMessage.  That way we can have a easy way to pick out "fatal errors"
where we stop processing the form. 

But we can do that in a seperate bug if you want.

r=me

Comment 11

[Doron Rosenberg (IBM)]

Using nsIConsoleMessage would mean I would have to create a nsIXFormsError that
implements it and all.  Doable, but I think warnings is good enough for now :)

Comment 12

[Doron Rosenberg (IBM)]

checked in.

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

or you can CI
http://lxr.mozilla.org/seamonkey/source/js/src/xpconnect/idl/nsIScriptError.idl#101