287729 - ChatZilla can't connect on Trunk builds (as of 2005-03-25)

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[:Gijs (he/him)]

Due to changes in nsIProtocolProxyService, the function examineForProxy ceased
to exist. It's replaced by the 'resolve' function. As we need to keep backwards
compatability, ChatZilla should learn to cope with both.

Comment 1

[:Gijs (he/him)]

Fixing summary, this also happens on Fx. Sorry for bugspam.

Comment 2

[:Gijs (he/him)]

Attachment: Patch taking care of compatability issues

Patch that simply checks which of the functions is present. To prevent this
from bugging out very quickly again, I set the default value to null, which
should usually just work for the rest of the connection (it indicates there's
no proxy).

Comment 3

[Robert Ginda]

Comment on attachment 178610 [details] [diff] [review]
Patch taking care of compatability issues

r=rginda

Comment 4

[Darin Fisher]

i wrote pretty much the same patch in bug 287690.  sorry for the bustage guys! 
i'll check in this patch instead of the one i wrote.

Comment 5

[Darin Fisher]

Comment on attachment 178610 [details] [diff] [review]
Patch taking care of compatability issues

this patch breaks PAC support.	please read nsIProtocolProxyService more
carefully.  passing RESOLVE_NON_BLOCKING is a big mistake.

Comment 6

[Darin Fisher]

Attachment: the patch i checked in

Comment 7

[:Gijs (he/him)]

Marking fixed based on the fix checked in for bug 287690.

Comment 8

[Joël Kuiper]

It's back....
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050326
Firefox/1.0+

Comment 9

[Bill Gianopoulos [:WG9s]]

(In reply to comment #8)
> It's back....
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050326
> Firefox/1.0+

That is because the fix went into the Chatzilla code, and not into Firefox.  You
need to install a version of chatzilla with the patch in it to fix the problem.

Comment 10

[:Gijs (he/him)]

*** Bug 288824 has been marked as a duplicate of this bug. ***