Closed Bug 287806 Opened 15 years ago Closed 10 years ago

Add TCP timeout pref

Categories

(SeaMonkey :: Preferences, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

(Blocks 1 open bug)

Details

(Keywords: fixed-seamonkey2.0)

Attachments

(2 files, 5 obsolete files)

We should expose the global mailnews.tcptimeout setting somewhere in the
mailnews prefs (equivalent of tb bug 284654)
The biggest question is where to put the new pref, in tb there is an advanced
prefs pane but the nearest equivalent on mailnews is Offline & Disk Space.
What I propose is that we rename Offline & Disk Space to Advanced and add the
new pref to there in a groupbox of either General/Other/Communication Settings.
Any thoughts?
Status: NEW → ASSIGNED
Attached image Proposed Pref Panel Update Screenshot (obsolete) —
Comment on attachment 178665 [details]
Proposed Pref Panel Update Screenshot

Oops
Attachment #178665 - Attachment description: Proposed Pref Panel Update Screenshit → Proposed Pref Panel Update Screenshot
Maybe we can find enough preferences to justify a new panel?
Actually, I'd rather go with what Ian proposes. Offline and Auto-compacting
folders are two unrelated things already, it may not harm to make that
"advanced". Though from a user perspective, that title doesn't tell much and
users might really look for Offline, while the other two prefs are clearly what
I'd label as "advanced". Actually, I'm not sure how frequently Offline is used
nowadays. If it's rarely used, it's OK for me to stick it into "advanced" and go
with what Ian proposed.

As to creating a new panel: I'd rather look how we can reduce the number of
panel than for how to increase it. With our current prefwindow, users already
have a hard time figuring out where to find stuff...
Or combine return receipts into notifications?

OTOH not adding Advanced may be avoiding the inevitable.
Ian,
Are you still working on this ?
This will probably get wrapped up in any post new pref window migration re-organisation.
Blocks: 436934
This patch:
* Renames Offline & Disk Space pref pane to Advanced.
* Adds "Other Settings" groupbox and expose mailnews.tcptimeout pref there.
* Updates help to reflect above changes.
Attachment #397741 - Flags: superreview?(neil)
Attachment #397741 - Flags: review?(mnyromyr)
Comment on attachment 397741 [details] [diff] [review]
Expose mailnews.tcptimeout preference patch v0.1

>+<!ENTITY mailnewsTimeout.label            "Connection timeout">
Needs a :

>+        <textbox id="mailnewsTimeoutSeconds"
>+                 type="number"
>+                 size="4"
>+                 preference="mailnews.tcptimeout"/>
Needs aria-labelledby (sp?)
Attachment #397741 - Flags: superreview?(neil) → superreview+
Comment on attachment 397741 [details] [diff] [review]
Expose mailnews.tcptimeout preference patch v0.1

>-<!ENTITY pref.offline.title               "Offline &amp; Disk Space">
>+<!ENTITY pref.mailnews_advanced.title     "Advanced">

I'm quite unhappy with "Advanced" here - the prefs on this panel aren't any more advanced than many others under Mail&News. How about "Miscellaneous" or just a plain "Other Settings" or "Other"?

Looks okay otherwise.

>+        <label value="&mailnewsTimeout.label;"
>+               accesskey="&mailnewsTimeout.accesskey;"
>+               control="mailnewsTimeoutSeconds"/>
>+        <textbox id="mailnewsTimeoutSeconds"
>+                 type="number"
>+                 size="4"
>+                 preference="mailnews.tcptimeout"/>
>+        <label value="&mailnewsTimeoutSeconds.label;"/>

The labels need ids for aria-labelledby on the textbox.
(In reply to comment #11)
> (From update of attachment 397741 [details] [diff] [review])
> >-<!ENTITY pref.offline.title               "Offline &amp; Disk Space">
> >+<!ENTITY pref.mailnews_advanced.title     "Advanced">
> 
> I'm quite unhappy with "Advanced" here - the prefs on this panel aren't any
> more advanced than many others under Mail&News. How about "Miscellaneous" or
> just a plain "Other Settings" or "Other"?
> 
How about we relabel "HTTP Networking" to be "Networking" under "Advanced" and put this pref there?
Looking at the code where this pref is used (IMAP and mailnews sockets in general), moving it outside the mailnews preferences scope would be a bit surprising.
Throwing it together with unrelated other mailnews prefs in one panel just to have it in mailnews is just about as unsuitable.

Basically, any panel named "other", "miscellaneous", or "advanced" shows of bad UI design ("we, uh, don't know how to group things properly so we just throw together a random collection of things") and is completely unintuitive for a user - and after all, we have UI prefs for users.
The harder to logically find we make things in pref panels, the more normal users will use about:config for being able to find things more easily (!) there - and IMHO, we already have way too many about:config users.
(In reply to comment #14)
> Basically, any panel named "other", "miscellaneous", or "advanced" shows of
> bad UI design ("we, uh, don't know how to group things properly so we just
> throw together a random collection of things") and is completely unintuitive
> for a user

That's the problem we are discussing right now, we just need a solution. :-þ
Attachment #397741 - Flags: review?(mnyromyr)
Changes since v0.1:
* Added aria-labelledby to textbox element.
* Pref pane now called "Network & Storage".
* Made disk space textbox type="number".
Attachment #397741 - Attachment is obsolete: true
Attachment #400383 - Flags: ui-review?(stefanh)
Attachment #400383 - Flags: superreview?(neil)
Attachment #400383 - Flags: review?(mnyromyr)
Attachment #178665 - Attachment is obsolete: true
Attachment #400383 - Flags: ui-review?(stefanh) → ui-review+
Comment on attachment 400383 [details] [diff] [review]
Network and Storage pref pane patch v0.1a

Looks good to me (ui-wise). I have some comments regarding the help changes:


In "Working Offline and Reconnecting Later" (mail_help), there's a reference to a "Synchronization & Storage category" in Preferences.b This is obviously wrong and it should reference to the new panel.

+  <li><strong>Mail Connections</strong>: Select this to manage mail connection
+    settings.</li>

There's nothing to select - You should say something about the timeout pref :P
Comment on attachment 400383 [details] [diff] [review]
Network and Storage pref pane patch v0.1a

>+            label="&pref.network_and_storage.title;"
We don't use _s in entity names. &pref.network.title; works best for me, as the alternative is the clumsy &pref.network.and.storage.title;

>+      <caption label="&mail_connections.caption;"/>
&mailConnections.caption;
Attachment #400383 - Flags: superreview?(neil) → superreview+
Blocks: 423281
(In reply to comment #18)
> (From update of attachment 400383 [details] [diff] [review])
> Looks good to me (ui-wise). I have some comments regarding the help changes:
> 
> 
> In "Working Offline and Reconnecting Later" (mail_help), there's a reference to
> a "Synchronization & Storage category" in Preferences.b This is obviously wrong
> and it should reference to the new panel.
It probably means the section in Account settings.
> 
> +  <li><strong>Mail Connections</strong>: Select this to manage mail connection
> +    settings.</li>
> 
> There's nothing to select - You should say something about the timeout pref :P
Will generate a new patch with more information.
Changes since v0.1a:
* Revised some entity names.
* Added more detail to help.

Requesting r from stefanh for help changes as well as r for code from Mnyromyr.
Attachment #400383 - Attachment is obsolete: true
Attachment #401118 - Flags: ui-review?(stefanh)
Attachment #401118 - Flags: superreview+
Attachment #401118 - Flags: review?(mnyromyr)
Attachment #400383 - Flags: review?(mnyromyr)
(In reply to comment #20)

> > In "Working Offline and Reconnecting Later" (mail_help), there's a reference to
> > a "Synchronization & Storage category" in Preferences.b This is obviously wrong
> > and it should reference to the new panel.
> It probably means the section in Account settings.

Nope. The text says (and note it's not the edit menu on mac):
"To set SeaMonkey Mail & Newsgroups' download behavior when going offline, open the SeaMonkey Edit menu, choose Preferences, and then click the Synchronization & Storage category. You can choose to have SeaMonkey Mail & Newsgroups prompt you to download messages when going offline, to automatically download messages, or to not download any messages."
Attachment #401118 - Flags: ui-review?(stefanh)
Attachment #401118 - Flags: review?(mnyromyr)
Changes since v0.1b:
* Revised issue with help stefanh pointed out (thanks).
Attachment #401118 - Attachment is obsolete: true
Attachment #401629 - Flags: ui-review?(stefanh)
Attachment #401629 - Flags: superreview+
Attachment #401629 - Flags: review?(mnyromyr)
Attachment #401629 - Flags: review?(mnyromyr) → review+
Attachment #401629 - Flags: ui-review?(stefanh) → review+
Comment on attachment 401629 [details] [diff] [review]
Network and Storage pref pane with revised help patch v0.1c

You know, you can ask multiple persons for review ;-)

r=me for the help changes .

Just one comment:
+  <li><strong>Mail Connections</strong>: Select how long you want Mail &amp;
+    Newsgroups to keep trying to contact the server before timing out.</li>

Is "select" really the right word here? Or should it rather be "choose" or "enter" (kind of tricky since you can do both)?
Changes since v0.1c:
* Changed Select to Choose in help.

Carrying forward r/sr and requesting a= for low risk patch.
Attachment #401629 - Attachment is obsolete: true
Attachment #401739 - Flags: superreview+
Attachment #401739 - Flags: review+
Attachment #401739 - Flags: approval-seamonkey2.0?
Attachment #401739 - Flags: approval-seamonkey2.0? → approval-seamonkey2.0+
Comment on attachment 401739 [details] [diff] [review]
Network and Storage pref pane and help patch v0.1d [Checkin: Comment 26]

http://hg.mozilla.org/comm-central/rev/0cb7f403694d
Attachment #401739 - Attachment description: Network and Storage pref pane and help patch v0.1d → Network and Storage pref pane and help patch v0.1d [Checkin: Comment 26]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.