Closed Bug 287924 Opened 20 years ago Closed 20 years ago

Bookmarks > Manage Bookmarks > Move does not work

Categories

(Firefox :: Bookmarks & History, defect, P1)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox1.5

People

(Reporter: stevee, Assigned: asaf)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

patch
1.12 KB, patch
mconnor
: review+
Details | Diff | Splinter Review 
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050327
Firefox/1.0+

1. Load Firefox
2. Choose Bookmarks > Manage Bookmarks
3. Highlight a bookmark with left click
4. Choose Edit > Move Bookmark, or click on the Move icon.
5. Choose a new location for your bookmark and click OK

Actual: Nothing Happens
Expected: Bookmark is moved to the new location
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050327
Firefox/1.0+

Confirmed

doesn't work via the [move] button either
Added keyword regression, since this works fine in Firefox 1.02
Keywords: regression
Due to bug 228165 checkin.
Depends on: 287885
OS: Windows 2000 → All
Hardware: PC → All
Assignee: vladimir+bm → bugs.mano
Flags: blocking-aviary1.1+
from the menus bug, but i'm still the bad boy ;)
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → Firefox1.1
Attached patch patch (obsolete) — — Splinter Review 
not like the other callers to addbookmark/2, the moveBookmark one was already
modal (because it needs its parent) on ALL/ALL, so my change was pretty wrong.

(I've moved over the orginal patch and there are no more instances of that).
Attachment #178735 - Flags: review?(mconnor)
No longer depends on: 287885
Comment on attachment 178735 [details] [diff] [review]
patch

wrong diff
Attachment #178735 - Attachment is obsolete: true
Attachment #178735 - Flags: review?(mconnor)
Attached patch patch — — Splinter Review 
again...
Attachment #178736 - Flags: review?(mconnor)
Attachment #178736 - Flags: review?(mconnor) → review+
Checking in bookmarks.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarks.js,v  <-- 
bookmarks.js
new revision: 1.97; previous revision: 1.96
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050327
Firefox/1.0+ 15:19PST

verified


sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
moving bookmarks with drag and drop doesn't work in the Firefox 10.0, in my system - it is needed to do cut and paste, which is annoying
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: