287987 - FindProviderFile should continue Enumerating on failed QI

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Justin Wood (:Callek)]

We should continue enumerating through providers if we fail this QI. 
FindProviderFile is a callback referenced at lines 623, and 635

Comment 1

[Justin Wood (:Callek)]

Attachment: continue enumerating

Comment 2

[Darin Fisher]

Comment on attachment 178770 [details] [diff] [review]
continue enumerating

or, you could write:

  if (prov) {
    // do stuff
  }

to be consistent with the nsIDirectoryServiceProvider2 case up above.

hmm... or, maybe we should output a NS_WARNING when the QIs fail.

Comment 3

[Justin Wood (:Callek)]

Attachment: continue enum (consistency)

Matches the consistency for when we QI to nsIDirectoryServiceProvider2; I opted
to leave out NS_WARNING here, since a provider may choose to provide for either
nsISimpleEnumerator, nsIFile, or both, and thus, missing the nsIFile case
should not spew "warnings" (all imho);

Porting r+sr from previous patch, requesting approval.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 180251 [details] [diff] [review]
continue enum (consistency)

a=asa

Comment 5

[Justin Wood (:Callek)]

checked in by timeless