Closed Bug 288011 Opened 17 years ago Closed 16 years ago
from bug 268264 comment 2 and 268264 comment 3: ------- Additional Comment #2 From Christian Biesinger (:bi) 2004-11-07 13:34 PST [reply] ------- hmm, is nsISSLSocketProvider needed at all? it has no methods or attributes. ------- Additional Comment #3 From Darin Fisher 2004-11-07 13:48 PST [reply] ------- yeah, i don't think there's any point to keeping nsISSLSocketProvider around.
I've had this in my tree for a while...
Attachment #178792 - Flags: review?(darin)
17 years ago
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta2
Comment on attachment 178792 [details] [diff] [review] patch maybe nsISSLSocketProvider.idl can go away too. I think the #defines can be moved into nsNetCID.h
Comment on attachment 178792 [details] [diff] [review] patch r=darin but please consider eliminating nsISSLSocketProvider.idl as suggested :-)
Attachment #178792 - Flags: review?(darin) → review+
OK, I eliminated nsISSLSocketProvider. I moved the contractid and classname of the SSL provider to nsSSLSocketProvider.h, since it wasn't used anywhere; I couldn't move the TLS contractid to nsTLSSocketProvider - LDAP depends on it, so I moved that one to nsNetCID.h.
Comment on attachment 179390 [details] [diff] [review] patch v2 r=darin if you move both contractids. exposing these publicly in nsNetCID.h is fine. that isn't the place for just frozen contracts, so it's fine to put them all there.
Attachment #179390 - Flags: review?(darin) → review+
ok, this patch moves the SSL contractid to nsNetCID.h too.
nit: break long lines in nsNetCID.h
Comment on attachment 179402 [details] [diff] [review] patch v3 sr=bzbarsky with the long lines nit addressed.
Attachment #179402 - Flags: superreview?(bzbarsky) → superreview+
Attachment #179402 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.