Closed Bug 288011 Opened 20 years ago Closed 20 years ago

eliminate nsISSLSocketProvider

Categories

(Core :: Networking, enhancement, P1)

Product:
Core
Component:
Networking
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8beta2

People

(Reporter: Biesinger, Assigned: Biesinger)

Details

Attachments

(1 file, 3 obsolete files)

final patch
11.41 KB, patch
Details | Diff | Splinter Review 
from bug 268264 comment 2 and 268264 comment 3:
 ------- Additional Comment #2 From Christian Biesinger (:bi)  2004-11-07 13:34
PST  [reply] -------

hmm, is nsISSLSocketProvider needed at all? it has no methods or attributes.


------- Additional Comment #3 From Darin Fisher 2004-11-07 13:48 PST [reply] -------

yeah, i don't think there's any point to keeping nsISSLSocketProvider around.
Attached patch patch (obsolete) — — Splinter Review 
I've had this in my tree for a while...
Attachment #178792 - Flags: review?(darin)
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta2
Comment on attachment 178792 [details] [diff] [review]
patch

maybe nsISSLSocketProvider.idl can go away too.  I think the #defines can be
moved into nsNetCID.h
Comment on attachment 178792 [details] [diff] [review]
patch

r=darin

but please consider eliminating nsISSLSocketProvider.idl as suggested :-)
Attachment #178792 - Flags: review?(darin) → review+
Attached patch patch v2 (obsolete) — — Splinter Review 
OK, I eliminated nsISSLSocketProvider. I moved the contractid and classname of
the SSL provider to nsSSLSocketProvider.h, since it wasn't used anywhere; I
couldn't move the TLS contractid to nsTLSSocketProvider - LDAP depends on it,
so I moved that one to nsNetCID.h.
Attachment #178792 - Attachment is obsolete: true
Attachment #179390 - Flags: review?(darin)
Comment on attachment 179390 [details] [diff] [review]
patch v2

r=darin if you move both contractids.  exposing these publicly in nsNetCID.h is
fine.  that isn't the place for just frozen contracts, so it's fine to put them
all there.
Attachment #179390 - Flags: review?(darin) → review+
Attached patch patch v3 (obsolete) — — Splinter Review 
ok, this patch moves the SSL contractid to nsNetCID.h too.
Attachment #179390 - Attachment is obsolete: true
Attachment #179402 - Flags: superreview?(bzbarsky)
nit: break long lines in nsNetCID.h
Comment on attachment 179402 [details] [diff] [review]
patch v3

sr=bzbarsky with the long lines nit addressed.
Attachment #179402 - Flags: superreview?(bzbarsky) → superreview+
Attached patch final patch — — Splinter Review 
lines broken
Attachment #179402 - Attachment is obsolete: true
checked in
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: