Closed
Bug 288049
Opened 20 years ago
Closed 14 years ago
"internal error" from ThrowCodeError is confusing
Categories
(Bugzilla :: User Interface, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.4
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
Attachments
(1 file)
|
1.17 KB,
patch
|
justdave
:
review+
|
Details | Diff | Splinter Review |
"Bugzilla has suffered an internal error. Please save this page and send it to..."
This is not a real internal error as Bugzilla has perfectly catched that some
informations were missing or invalid. This error message should be improved a bit.
|
Assignee | |
Comment 1•20 years ago
|
||
Moreover, if the user is hacking the URL and Bugzilla fails, then it should not
say "report it to the maintainer".
I suggested something like "Under normal conditions, this error should not
appear. If you were not hacking the URL then this could indicate an error in
Bugzilla and you should report it to <maintainer>", but justdave said it was too
complicated still.
Any other suggestion?
Severity: normal → enhancement
|
|
Assignee | |
Updated•18 years ago
|
Assignee: myk → ui
|
|
Assignee | |
Comment 2•14 years ago
|
||
The rewording takes bug 193968 into account and will also fix it. We no longer mention "internal error" which is really frightening and inaccurate (a "Software Error" is an internal error, though, but when this happens, Bugzilla dies before ThrowCodeError() has been called).
Assignee: ui → LpSolit
Status: NEW → ASSIGNED
Attachment #551051 -
Flags: review?(justdave)
Attachment #551051 -
Flags: review?(glob)
|
|
Assignee | |
Updated•14 years ago
|
Target Milestone: --- → Bugzilla 5.0
|
||
Comment 3•14 years ago
|
||
Comment on attachment 551051 [details] [diff] [review]
patch, v1
Review of attachment 551051 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #551051 -
Flags: review?(justdave) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #551051 -
Flags: review?(glob)
|
|
Assignee | |
Updated•14 years ago
|
Flags: approval?
|
|
Assignee | |
Updated•14 years ago
|
Flags: approval? → approval+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/global/code-error.html.tmpl
Committed revision 7898.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•