288051 - simple boolean checking of get_index_def's return value is error-prone

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Simple boolean checking of get_index_def's return value is error-prone, since
multi-column indexes are listed one column at a time, so an index on columns
(foo, bar) of table "baz" will cause get_index_def("baz","bar") to return a true
value even though that index may not satisfy the need for which get_index_def
was called, since if you are searching just "bar" instead of both columns you
won't be able to use that multi-column index.

Comment 1

[Max Kanat-Alexander]

Oh, definitely known. All the old schema-checking functions have logical errors
in them, pretty much.

They are all going away as part of bug 285722, and being replaced with much
nicer functions that work sanely. :-)

Comment 2

[Myk Melez [:myk] [@mykmelez]]

"If it's not a regression from 2.18 and it's not a critical problem with
something that's already landed, let's push it off." - Dave

Comment 3

[Frédéric Buclin]

mkanat, is this bug fixed now?

Comment 4

[Max Kanat-Alexander]

Yeah. Fixed by blocker.