288075 - -browser and -chrome are identical options

Status: RESOLVED FIXED

(Core Graveyard :: Cmd-line Features, defect)

Description

[[e-mail]]

Although not clear from help the -browser and -chrome options function
identically in that they open the given parameter into a chrome window otherwise
opening a browser window. However people expect -browser <URL> to open the URL
into a browser window, although more accurately would be to a) open a browser
window and b) open a second browser window (or perhaps a new tab) for the URL.

Comment 1

[Benjamin Smedberg]

Hrm, -browser wasn't supposed to open a chrome window, it was supposed to open a browser window. 
That sounds like a bug.

Comment 2

[[e-mail]]

Attachment: First draft

This patch doesn't change the behaviour of a bare -chrome parameter.

Comment 3

[[e-mail]]

Comment on attachment 178916 [details] [diff] [review]
First draft

>-CMDLINEHANDLER_OTHERS_IMPL(nsBrowserContentHandler,"-chrome","general.startup.browser","Load the specified chrome.", PR_TRUE, PR_FALSE)
>+CMDLINEHANDLER_OTHERS_IMPL(nsBrowserContentHandler,"-chrome","general.startup.browser","Load the specified chrome.", PR_TRUE, PR_TRUE)
Please imagine I've renamed this one to "-browser", "Load the browser."

Comment 4

[Darin Fisher]

Comment on attachment 178916 [details] [diff] [review]
First draft

ugh.. someone should break these long lines :(

sr=darin (bonus points for breaking long lines at 80 chars)

Comment 5

[[e-mail]]

Fix checked in.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This caused bustage. I checked in this fix, hope it's the right fix:

http://tinderbox.mozilla.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/xpfe/components/build&command=DIFF_FRAMESET&file=nsModule.cpp&rev1=1.51&rev2=1.52&root=/cvsroot

Comment 7

[[e-mail]]

(In reply to comment #6)
>This caused bustage. I checked in this fix, hope it's the right fix:
$ cvs up nsModule.cpp
RCS file: /cvsroot/mozilla/xpfe/components/build/nsModule.cpp,v
retrieving revision 1.51
retrieving revision 1.52
Merging differences between 1.51 and 1.52 into nsModule.cpp
nsModule.cpp already contains the differences between 1.51 and 1.52
$

Thanks roc :-[