288083 - format_time should allow different time/date formats

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

Now that all timestamp fields have been removed from the DB, bug 156834, a part
of the code from format_time() in Util.pm is now useless:

    if ($time =~ m/^\d{14}$/) {
        # We appear to have a timestamp direct from MySQL

Moreover, as part of bug 287487 comment 5, this function does not allow me to
choose the "%Y-%m-%d" format or any other format we could need. Then it appears
necessary to extend its capability to accept different time formats as a parameter.

I will try to make it backward compatible with the existing code in order to
change as few code as possible.

Comment 1

[Max Kanat-Alexander]

Remember that the sole current purpose of format_time is to standardize date
display throughout all of Bugzilla.

If it does allow custom formats, it should make sure to always leave open the
option of not specifying a format, and the POD docs should specify that that is
the preferred use for displaying a date in Bugzilla.

Comment 2

[Frédéric Buclin]

format_time() now allows you to specify the default time format, see bug 287487.
Fixed!