288095 - Unnecessary private exports from lib/softoken

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Wan-Teh Chang]

lib/softoken/manifest.mn lists alghmac.h and pkcs11i.h
in PRIVATE_EXPORTS.  But pkcs11i.h is not included by
any file outside lib/softoken, and even though there
are four files outside lib/softoken that include alghmac.h,
those inclusions are not necessary.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch

I also deleted an unused local variable that's unrelated
to this bug.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

bltest should test HMAC.  But it probably doesn't.  :-(

Comment 3

[Wan-Teh Chang]

It seems that alghmac.{h,c} really belong in freebl
as opposed to softoken.

Comment 4

[Robert Relyea]

Comment on attachment 178881 [details] [diff] [review]
Proposed patch

r+

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 178881 [details] [diff] [review]
Proposed patch

Wan-Teh, I think it would be fine to check this in for 3.10.

Comment 6

[Wan-Teh Chang]

OK. Patch checked in on the NSS trunk for NSS 3.10.

Checking in pk11wrap/pk11pbe.c;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11pbe.c,v  <--  pk11pbe.c
new revision: 1.11; previous revision: 1.10
done
Checking in pkcs12/p12d.c;
/cvsroot/mozilla/security/nss/lib/pkcs12/p12d.c,v  <--  p12d.c
new revision: 1.27; previous revision: 1.26
done
Checking in pkcs12/p12e.c;
/cvsroot/mozilla/security/nss/lib/pkcs12/p12e.c,v  <--  p12e.c
new revision: 1.12; previous revision: 1.11
done
Checking in pkcs12/p12local.c;
/cvsroot/mozilla/security/nss/lib/pkcs12/p12local.c,v  <--  p12local.c
new revision: 1.8; previous revision: 1.7
done
Checking in softoken/manifest.mn;
/cvsroot/mozilla/security/nss/lib/softoken/manifest.mn,v  <--  manifest.mn
new revision: 1.22; previous revision: 1.21
done