Closed Bug 288160 Opened 20 years ago Closed 20 years ago

Code checked in for bug 237776 (reload button should be disabled for blank tabs) is wrong when frames are involved

Categories

(Firefox :: Toolbars and Customization, defect, P1)

Product:
Firefox
Component:
Toolbars and Customization
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox1.5

People

(Reporter: bzbarsky, Assigned: Gavin)

References

Details

Attachments

(1 file)

Patch
2.45 KB, patch
mconnor
: review+
asa
: approval-aviary1.1a1+
Details | Diff | Splinter Review
See bug 237776 comment 23 and the testcase that shows what the problem is in attachment 178827 [details].
Blocks: 237776
Severity: normal → major
Flags: blocking-aviary1.1?
OS: Linux → All
Hardware: PC → All
Flags: blocking-aviary1.1? → blocking-aviary1.1+
Summary: Code checked in for bug 237776 is wrong when frames are involved → Reload should be disabled for blank tabs is wrong when frames are involved
I have now idea what happened but somehow I messed with the title adding myself to the CC list. I didn't even touch that field
Summary: Reload should be disabled for blank tabs is wrong when frames are involved → Code checked in for bug 237776 is wrong when frames are involved
Attached patch Patch — — Splinter Review
Just move the code.
Assignee: ryanvm → gavin.sharp
Status: NEW → ASSIGNED
Attachment #179108 - Flags: review?(mconnor)
Priority: -- → P1
Summary: Code checked in for bug 237776 is wrong when frames are involved → Code checked in for bug 237776 (reload button should be disabled for blank tabs) is wrong when frames are involved
Whiteboard: [patch-r?]
Target Milestone: --- → Firefox1.1
Attachment #179108 - Flags: review?(mconnor) → review+
Attachment #179108 - Flags: approval-aviary1.1a?
Whiteboard: [patch-r?] → [patch-r+] [checkin needed]
Comment on attachment 179108 [details] [diff] [review] Patch a=asa
Attachment #179108 - Flags: approval-aviary1.1a? → approval-aviary1.1a+
Whiteboard: [patch-r+] [checkin needed] → [patch-r+][checkin needed][a+]
Checked in by timeless.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: [patch-r+][checkin needed][a+]
QA Contact: bugzilla → toolbars
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: