Closed Bug 288177 Opened 20 years ago Closed 20 years ago

Get rid of embed-sample.jar for toolkit apps

Categories

(Toolkit Graveyard :: Build Config, defect)

Product:
Toolkit Graveyard
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sipaq, Assigned: sipaq)

References

Details

Attachments

(1 file)

patch v1
695 bytes, patch
benjamin
: first-review+
darin.moz
: second-review+
Details | Diff | Splinter Review 
Sunbird doesn't need embed-sample.jar, Firefox doesn't want it according to bug
171082 comment 10 and I guess Thunderbird also wants to go without it.
Assignee: nobody → benjamin
Attached patch patch v1 — — Splinter Review 
Assignee: benjamin → bugzilla
Status: NEW → ASSIGNED

        Attachment #178947 -
        Flags: first-review?(benjamin)

    
    

    
  
Comment on attachment 178947 [details] [diff] [review]
patch v1

I would like darin to approve this as well, but it looks good to me.

        Attachment #178947 -
        Flags: second-review?(darin)

        Attachment #178947 -
        Flags: first-review?(benjamin)

        Attachment #178947 -
        Flags: first-review+

    
    

    
  
Comment on attachment 178947 [details] [diff] [review]
patch v1

sr=darin

        Attachment #178947 -
        Flags: second-review?(darin) → second-review+

    
    

    
  
Committed a variant after discussion with Darin and Simon:

DIRS = webBrowser build
ifndef MOZ_XUL_APP
DIRS += chrome
endif

Thanks, Simon.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 178947 [details] [diff] [review]
patch v1

>+ifdef MOZ_XUL_APP
>+DIRS=webBrowser build
>+else if
> DIRS=webBrowser build chrome
>+endif

So, actually the " if" after "else" is bogus.  And, I think it would
be better to write this as:

DIRS = webBrowser build

ifndef MOZ_XUL_APP
DIRS += chrome
endif

    
  
Product: Toolkit → Toolkit Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: