28818 - MLK: profile migration, node->GetNameUTF8(&profile)

Status: VERIFIED FIXED

(Core Graveyard :: Profile: BackEnd, defect, P3)

Description

[Bruce Mitchener]

From beard's leak data.
/mozilla/profile/src/nsProfileAccess.cpp:
 850              char *profile = nsnull;
 851         rv = node->GetNameUTF8(&profile);

that isn't freed at all.  It can be freed anywhere after line 891.  It also 
needs to be freed for the return statements at lines 859, 867, 880, and 902.

Comment 1

[Bruce Mitchener]

I'd have done a patch and tested it, but I'm on Solaris and Linux and this bug 
doesn't exist there.

Comment 2

[Daniel Veditz [:dveditz]]

I'm reasigning to Gayatri, she is re-writing this section to use PRUnichar for 
profile names. As part of my first-pass code review of that section I've 
suggested she switch to nsXPIDLString where appropriate.

Comment 3

[gayatrib]

Working on fixing this and similar leaks. Should be ready with the fixes in the 
next few days.

Comment 4

[selmer (gone)]

not serious enough to mark beta1.

Comment 5

[gayatrib]

checked in fix.

Comment 6

[Grace Bush]

Congratulations!  So far, your changes look good under Purify and I'm not 
seeing the memory leaks. 

Bruce

Comment 7

[Bruce Mitchener]

(Did I say that on some other bug?)