MLK: profile migration, node->GetNameUTF8(&profile)

VERIFIED FIXED in M15

Status

P3
normal
VERIFIED FIXED
19 years ago
3 years ago

People

(Reporter: bruce, Assigned: gayatrib)

Tracking

({memory-leak})

Trunk
x86
Windows NT
memory-leak

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

19 years ago
From beard's leak data.
/mozilla/profile/src/nsProfileAccess.cpp:
 850              char *profile = nsnull;
 851         rv = node->GetNameUTF8(&profile);

that isn't freed at all.  It can be freed anywhere after line 891.  It also 
needs to be freed for the return statements at lines 859, 867, 880, and 902.
(Reporter)

Comment 1

19 years ago
I'd have done a patch and tested it, but I'm on Solaris and Linux and this bug 
doesn't exist there.
I'm reasigning to Gayatri, she is re-writing this section to use PRUnichar for 
profile names. As part of my first-pass code review of that section I've 
suggested she switch to nsXPIDLString where appropriate.
Assignee: selmer → gayatrib
(Assignee)

Comment 3

19 years ago
Working on fixing this and similar leaks. Should be ready with the fixes in the 
next few days.
Status: NEW → ASSIGNED

Comment 4

19 years ago
not serious enough to mark beta1.
Target Milestone: M15
(Assignee)

Comment 5

19 years ago
checked in fix.
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED

Comment 6

19 years ago
Congratulations!  So far, your changes look good under Purify and I'm not 
seeing the memory leaks. 

Bruce
Status: RESOLVED → VERIFIED
(Reporter)

Comment 7

19 years ago
(Did I say that on some other bug?)
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.