Closed
Bug 288192
Opened 19 years ago
Closed 19 years ago
Rebrand bootstrap's leftover Mac bits
Categories
(SeaMonkey :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey1.0alpha
People
(Reporter: kairo, Unassigned)
References
Details
Here's the things on mac I'm still unsure what to do about or haven't done anything about yet: mozilla/xpfe/bootstrap/appleevents/mozilla.sdef:5:This file describes Mozilla's AppleScript dictionary. It's compiled into a .r file mozilla/xpfe/bootstrap/appleevents/mozilla.sdef:7:/Developer/Tools/sdp -f a mozilla.sdef mozilla/xpfe/bootstrap/appleevents/mozilla.sdef:11: <suite name="Mozilla" code="MOZZ"> mozilla/xpfe/bootstrap/appleevents/Makefile.in:79: nsAEMozillaSuiteHandler.cpp \ mozilla/xpfe/bootstrap/appleevents/Makefile.in:114:SDEF_SRC = $(srcdir)/mozilla.sdef mozilla/xpfe/bootstrap/appleevents/Makefile.in:115:RES_DEST = mozillaSuite.r mozilla/xpfe/bootstrap/appleevents/Makefile.in:116:RSRC_DEST = mozillaSuite.rsrc mozilla/xpfe/bootstrap/macbuild/Contents/Info.plist.in:22: <string>mozilla.icns</string>
Comment 1•19 years ago
|
||
The only thing that you might want to fix here is: mozilla/xpfe/bootstrap/appleevents/mozilla.sdef:11: <suite name="Mozilla" code="MOZZ"> but that's only going to be seen by people opening the AppleScript dictionary with Script Editor.
Updated•19 years ago
|
Summary: Rebrand bootstrap's left over Mac bits → Rebrand bootstrap's leftover Mac bits
Reporter | ||
Comment 2•19 years ago
|
||
OK, I'll do hardcoded rebranding of this one with my rebranding patch. Keeping this one open and blocking the alpha, as this is a tier-1 platform.
Status: NEW → ASSIGNED
Flags: blocking-seamonkey1.0a+
Target Milestone: --- → Seamonkey1.0alpha
Reporter | ||
Comment 3•19 years ago
|
||
OK, this landed along with the stage 2 checkin of bug 285696, should be fixed.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 4•19 years ago
|
||
I'm not quite sure where /xpfe/bootstrap/macbuild/mozilla.icns is used actually, but it's not used as app icons - Mac builds are still showing the Mozilla M. We need to copy (move?) this mozilla.icns into /xpfe/bootstrap/macbuild/Contents/Resources/, too. I can do that, I just need to know whose r/sr/a I need...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 5•19 years ago
|
||
OK, so the reason why the appmenu and it's items still has Mozilla is because of this: http://lxr.mozilla.org/seamonkey/source/xpfe/bootstrap/macbuild/Contents/Resources/English.lproj/InfoPlist.strings?raw=1
Comment 6•19 years ago
|
||
Okay, removed the updated, but unused for ages, mozilla.icns and updated the correct one to use CTho's fantastic piece of art. ;-) Removing mozilla.icns; /cvsroot/mozilla/xpfe/bootstrap/mozilla.icns,v <-- mozilla.icns new revision: delete; previous revision: 1.2 done Checking in macbuild/Contents/Resources/mozilla.icns; /cvsroot/mozilla/xpfe/bootstrap/macbuild/Contents/Resources/mozilla.icns,v <-- mozilla.icns new revision: 1.2; previous revision: 1.1 done
Reporter | ||
Comment 7•19 years ago
|
||
Close this, as the app menu has its own bug and the rest seems to be fixed.
Status: REOPENED → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•