288201 - coverity warnings in embedding

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Embedding: GRE Core, defect)

Description

[Doug Turner (:dougt)]

Comment 1

[Doug Turner (:dougt)]

Attachment: Patch v.1

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 178972 [details] [diff] [review]
Patch v.1

The first file should not be patched -- Coverity is missing the relationship
between Count() returning non-zero implying mImpl is non-null and i is in
bounds.

/be

Comment 3

[Doug Turner (:dougt)]

Checking in browser/gtk/src/gtkmozembed2.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembed2.cpp,v  <--  gtkmozembed2.cpp
new revision: 1.43; previous revision: 1.42
done
Checking in components/commandhandler/src/nsCommandGroup.cpp;
/cvsroot/mozilla/embedding/components/commandhandler/src/nsCommandGroup.cpp,v 
<--  nsCommandGroup.cpp
new revision: 1.11; previous revision: 1.10
done

Comment 4

[Doug Turner (:dougt)]

There are a few other warning I should address before marking fixed.

Comment 5

[Doug Turner (:dougt)]

mass reassigning to nobody.

Comment 6

[Benjamin Smedberg]

Mass change of bugs in the "Embedding: GRE Core" component in preparation for archiving it. I believe that these are no longer relevant; but if they are, they should be reopened and moved into a component relevant to the code in question.