288204 - Linker error on libfileview.so when building xulrunner

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Rob Adams]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.6) Gecko/20050324 Firefox/1.0 (Ubuntu package 1.0.2)
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.6) Gecko/20050324 Firefox/1.0 (Ubuntu package 1.0.2)

 /usr/bin/ld: cannot find -lxul
collect2: ld returned 1 exit status
make[6]: *** [libfileview.so] Error 1 

Reproducible: Always

Steps to Reproduce:

Comment 1

[Rob Adams]

Attachment: Patch which fixes the problem for xulrunner

Comment 2

[Benjamin Smedberg]

Comment on attachment 178977 [details] [diff] [review]
Patch which fixes the problem for xulrunner

cool, I'll check this in when I find my desk again.

Comment 3

[Darin Fisher]

Hmm.. my linux xulrunner build does not have this problem for some reason.

Comment 4

[Rob Adams]

What about if you do a distclean first?

Comment 5

[Darin Fisher]

ok, starting a fresh build...

Comment 6

[Benjamin Smedberg]

Darin, this would only be manifest if we need the XUL filepicker, I think: GTK2
and windows use native filepickers and wouldn't build this binary, if I'm
reading the Makefiles correctly.

Comment 7

[Rob Adams]

Attachment: .mozconfig

I was doing a gtk2 build.  Here's the .mozconfig.

Comment 8

[Darin Fisher]

Yeah, I hit this problem too in a GTK2 build.  In my case, it was an optimized,
clobber build.

Comment 9

[Benjamin Smedberg]

*** Bug 288421 has been marked as a duplicate of this bug. ***

Comment 10

[Wolfgang Rosenauer [:wolfiR]]

only a side-comment about filepickers.
gtk2 filepicker is now the default but I think that the xul filepicker should be
available in addition. It would be needed anyway on systems with GNOME older
than 2.4. Mozilla Application Suite's gtk2 builds have both filepickers. So it
looks correctly here that XUL picker is built.

Another thing: My bug which was resolved as duplicate shows not exactly the same
error. My build asks for -lxpcom and not -lxul. But that could be because I
didn't define "ac_add_options --enable-libxul" (I've thought that's implicit
with xulrunner?)

Comment 11

[Benjamin Smedberg]

fixed on trunk. I actually checked in a smaller set of changes, because the
libxul path never comes close to tbird/sunbird.