Closed Bug 288212 Opened 15 years ago Closed 15 years ago

cleanup nsAutoConfig::getEmailAddr and nsReadConfig::readConfigFile

Categories

(Core :: Preferences: Backend, defect, minor)

x86
Windows XP
defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug)

Details

(Keywords: coverity)

Attachments

(1 obsolete file)

use IsEmpty() and don't create useless nsDependent(C)Strings
Attached patch proposed patch to bug 288212 (obsolete) — Splinter Review
cleaned up nsAutoConfig::getEmailAddr and nsReadConfig::readConfigFile.
code compiles without any errors.
Attachment #179345 - Flags: superreview?(alecf)
Attachment #179345 - Flags: review?(alecf)
Comment on attachment 179345 [details] [diff] [review]
proposed patch to bug 288212

r/sr=alecf
Attachment #179345 - Flags: superreview?(alecf)
Attachment #179345 - Flags: superreview+
Attachment #179345 - Flags: review?(alecf)
Attachment #179345 - Flags: review+
Attachment #179345 - Flags: approval1.8b3?
Comment on attachment 179345 [details] [diff] [review]
proposed patch to bug 288212

a=shaver
Attachment #179345 - Flags: approval1.8b3? → approval1.8b3+
Comment on attachment 179345 [details] [diff] [review]
proposed patch to bug 288212

mozilla/extensions/pref/autoconfig/src/nsReadConfig.cpp 	1.15
mozilla/extensions/pref/autoconfig/src/nsAutoConfig.cpp 	1.18
Attachment #179345 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.