288242 - Bad accessible object shutdown procedure

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[Aaron Leventhal]

The loop in nsAccessible::Shutdown() is supposed to walk through the children
and make sure none of them point to it anymore.

The problem is the GetNextSibling() used in the loop creates a parent if there
is none, and we're setting the parent to null for that child before we call
GetNextSibling() on it.

Comment 1

[Aaron Leventhal]

Attachment: Simple patch to switch order of 2 lines, set the parent to null after we have the next sibling from it

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 179019 [details] [diff] [review]
Simple patch to switch order of 2 lines, set the parent to null after we have the next sibling from it

sr=dmose

Comment 3

[Aaron Leventhal]

Checking in accessible/src/base/nsAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessible.cpp,v  <--  nsAccessible.cpp
new revision: 1.140; previous revision: 1.139
done

Comment 4

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381