288266 - Save complete page stores compressed files without extension indicating compression

Status: RESOLVED WONTFIX

(Core Graveyard :: File Handling, defect)

Description

[Klaus Johannes Rusch]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040910
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040910


When saving a complete page, embedded resources which were received with gzip
compression are stored compressed but with the original extension.

Reproducible: Always

Steps to Reproduce:



Expected Results:  

Either save the uncompressed version (preferred) or change the filename and
links to indicate compression

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

oh god, not another one of these

do you have an example url? this is supposed to work.

Comment 2

[Klaus Johannes Rusch]

Attachment: Sample page demonstrating the problem

The attached sample page demonstrates the problem.
The embedded http://pagead2.googlesyndication.com/pagead/show_ads.js is saved
as show_ads containing the gzipped script code without an extension.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

hm, indeed. I can reproduce this, but only on the 1.7 branch, not on trunk.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

oh cool. The problem seems to be that the frontend defaults to not decoding,
especially in the case where the main page is not encoded (so for that request,
it doesn't matter).
So it sets PERSIST_FLAGS_NO_CONVERSION.

Now, wbp seems to check that flag for each request it makes, as far as I
understand EnumPersistURIs, also for subdocuments/scripts. This means that it
will never uncompress any subdocuments if the main document is not compressed.

This likely works on trunk due to the new autodetect conversion flag, where wbp
checks for each request whether conversion should be applied.

Should we bother fixing this for 1.7.x?

Comment 5

[Boris Zbarsky [:bzbarsky]]

I guess on 1.7 we could just auto-detect only for sub-resources....  On the
other hand, drivers have clearly said that the only non-security fixes they'll
take on 1.7 had better be really badly needed, and I'm not sure this really
qualifies.

Comment 6

[Boris Zbarsky [:bzbarsky]]

I'm going to WONTFIX this as a branch bug.... the relevant api changes aren't
goign to make it to branch.