Save complete page stores compressed files without extension indicating compression

RESOLVED WONTFIX

Status

Core Graveyard
File Handling
--
minor
RESOLVED WONTFIX
13 years ago
2 years ago

People

(Reporter: Klaus Johannes Rusch, Unassigned)

Tracking

1.7 Branch
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: Fixed on trunk)

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040910
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040910


When saving a complete page, embedded resources which were received with gzip
compression are stored compressed but with the original extension.

Reproducible: Always

Steps to Reproduce:



Expected Results:  

Either save the uncompressed version (preferred) or change the filename and
links to indicate compression
oh god, not another one of these

do you have an example url? this is supposed to work.
Assignee: general → file-handling
Component: General → File Handling
Product: Mozilla Application Suite → Core
QA Contact: general → ian
Version: unspecified → 1.7 Branch
(Reporter)

Comment 2

13 years ago
Created attachment 179042 [details]
Sample page demonstrating the problem


The attached sample page demonstrates the problem.
The embedded http://pagead2.googlesyndication.com/pagead/show_ads.js is saved
as show_ads containing the gzipped script code without an extension.
hm, indeed. I can reproduce this, but only on the 1.7 branch, not on trunk.
oh cool. The problem seems to be that the frontend defaults to not decoding,
especially in the case where the main page is not encoded (so for that request,
it doesn't matter).
So it sets PERSIST_FLAGS_NO_CONVERSION.

Now, wbp seems to check that flag for each request it makes, as far as I
understand EnumPersistURIs, also for subdocuments/scripts. This means that it
will never uncompress any subdocuments if the main document is not compressed.

This likely works on trunk due to the new autodetect conversion flag, where wbp
checks for each request whether conversion should be applied.

Should we bother fixing this for 1.7.x?
I guess on 1.7 we could just auto-detect only for sub-resources....  On the
other hand, drivers have clearly said that the only non-security fixes they'll
take on 1.7 had better be really badly needed, and I'm not sure this really
qualifies.
I'm going to WONTFIX this as a branch bug.... the relevant api changes aren't
goign to make it to branch.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → WONTFIX
Whiteboard: Fixed on trunk
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.