288322 - Generic impl for Mac's Application menu

Status: NEW

(Core :: Widget: Cocoa, defect, P5)

Description

[jhp (no longer active)]

Coming off of a discussion with Mano on Bug 258277...

We need a more generic way to handle menu items that need to be put in the
Application Menu.  Currently, we have special code in nsMenuBarX.cpp to handle
individual items (About, Preferences, Quit, and now 'Check for Update').

Mano suggested handling this mostly in XUL.  We create a Mac only menu
("MacApplicationMenu"), and add the items we want, in the order we want them. 
Then we #ifdef out the items from their normal locations.  The code in
nsMenuBarX would just need to look for the menu id and generically handle it. 
New items would be added to the XUL menu, without needing to touch nsMenuBarX again.

How does this sound?

Comment 1

[Asaf Romano (gone)]

(About, Preferences, Quit should remain special cased.)

Comment 2

[Asaf Romano (gone)]

Neil: can we use the <menu> type attribute for that?

Also, I think we don't want to show this menu on other platforms.

Comment 3

[Jo Hermans]

is this also for bug 283791 ?

Comment 4

[Asaf Romano (gone)]

Yes.

Comment 5

[[e-mail]]

You don't need a whole <menu> for that, a <commandset> would do.

Comment 6

[jhp (no longer active)]

I don't know much about <commandset>, but we would need to have access to the
menu label, so we can add that text to the application menu.  Can that be
specified in a <commandset>?

Comment 7

[Asaf Romano (gone)]

Yes, we'll probably have something like that:

<commandset id="macAppMenu">
  <command id="..." oncommand="..." label="...">
  ...
</commandset>

Comment 8

[:Gijs (he/him)]

Would this approach be able to deal with dynamically added items?