288331 - [FIX]Removing type attribute on an <input type="checkbox"> does not work

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P1)

Description

[Doron Rosenberg (IBM)]

Removing type attribute on an <input type="checkbox"> does not work, one would
assume it should change the input to look like a regular textbox.

The weird thing is, on Linux GTK2, it remains a checkbox, which can be checked
and unchecked. On windows, it seems to become a regular input, but you can't
type anything into it.

Seen on trunk and 1.7 as well.

Comment 1

[Doron Rosenberg (IBM)]

Attachment: testcase

Comment 2

[José Jeria]

With an ancient build (gecko 1.0.1), clicking on the button makes the checkbox
converts to a textbox with the value "on"

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

I think the comment in the diff pretty much explains what's going on here...

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 179095 [details] [diff] [review]
Fix

This is basically a one-liner; should be a very quick review.

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 179095 [details] [diff] [review]
Fix

r+sr=jst

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed.