28838 - make distclean does not work as expected

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Joe Pranevich]

Using the latest cvs available source, I am unable to perform a "make distclean"
on the source repository to clean out the created files and return to a pristine
tree. The option is in the Makefile, however it errors after deleting some of
the files. 

I have appended the output from "make distclean" on my system. I have also
appended the result of "find ./ -name *.o" in my tree. If "make distclean"
worked properly, this find should not return any items. (the distclean should
also remove the extra autoconf files and any other built objects that were
created after checking out the tree)

Comment 1

[Joe Pranevich]

Attachment: "make distclean" output

Comment 2

[Joe Pranevich]

Attachment: Results of "find ./ -name *.o"

Comment 3

[cls]

Use 'make -f client.mk cleansrcdir' instead.  If building in an objdir, you can
just delete the entire directory and start new.  It's not optimal (or even
preferred) but it works and is why 'make distclean' is still broken. :-/

Comment 4

[cls]

Attachment: working distclean patch for mozilla

Comment 5

[cls]

Attachment: working distclean target for nspr

Comment 6

[cls]

wtc: attachment 5793 [details] [diff] [review] implements distclean for nspr.  It returns the tree to the
state it was in before you ran configure...with the exception of the created
directories (in an objdir build).  It will also remove the generated Makefiles
if USE_AUTOCONF is defined.  Currently, the autoconf nspr build can only be used
in an objdir so it won't clobber the classic Makefiles.

Comment 7

[Jim Roskind]

PDT-  sorry... this won't cause us to hold beta1

Comment 8

[Wan-Teh Chang]

Attachment: revised distclean patch for nspr.

Comment 9

[Wan-Teh Chang]

The distclean target for nspr is tracked by
a separate bug (#29427).

Comment 10

[cls]

Checked in patch from 29427 to NSPRPUB_CLIENT_BRANCH.

Comment 11

[Wan-Teh Chang]

The distclean target for nspr doesn't need
to go into NSPRPUB_CLIENT_BRANCH.  The lack
of a distclean target for nspr is not a
serious problem.  This can wait until NSPR
4.1.

NSPRPUB_CLIENT_BRANCH should only receive
NSPR releases and fixes for critical bugs.

Comment 12

[Mario Gomes]

Attachment: attachment.txt

Comment 13

[Mario Gomes]

Comment on attachment 8847292 [details]
attachment.txt

sorry...