288397 - HP-UX: support long hostname

Status: RESOLVED FIXED

(Directory :: LDAP C SDK, defect)

Description

[Noriko Hosoi]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

HP sent a request to allow them to use longer hostname.  Currently,
MAXHOSTNAMELEN is set to 64.  Could you please apply the following patch?

ldapsdk components
===================

###########################################################
# ./mozilla/directory/c-sdk/ldap/libraries/libldap/open.c #
###########################################################
47a48,54

>> #if defined(__hpux)
>> #if (MAXHOSTNAMELEN < 256)
>> #   undef MAXHOSTNAMELEN
>> #   define MAXHOSTNAMELEN 256
>> #endif
>> #endif
>> 


Reproducible: Always

Steps to Reproduce:
Use hostname longer than 64 characters and shorter than 255 characters.

Comment 1

[Mark Smith [:mcs]]

OK, but I do not see where MAXHOSTNAMELEN is used in the code.  Is it used
indirectly (affecting some header that is included later)?  I don't see it.

Comment 2

[Rich Megginson]

Attachment: Diffs to remove MAXHOSTNAMELEN definition

Since the definition is not used anywhere, the best solution is to just remove
it.

Comment 3

[Rich Megginson]

Mark, do you want to reassign this bug to me?  Also, change the OS to HP-UX.

Comment 4

[Mark Smith [:mcs]]

Reassigned to Rich.

Comment 5

[Mark Smith [:mcs]]

Comment on attachment 180803 [details] [diff] [review]
Diffs to remove MAXHOSTNAMELEN definition

Looks good to me.  Please commit when you have a chance.

Comment 6

[Rich Megginson]

Checking in mozilla/directory/c-sdk/ldap/libraries/libldap/open.c;
/cvsroot/mozilla/directory/c-sdk/ldap/libraries/libldap/open.c,v  <--  open.c
new revision: 5.6; previous revision: 5.5