288405 - Attachment.cgi fails on Big File attachment inserts on 2.19.2+ cvs tip - 03305 current

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Tim Thome]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2
Build Identifier: 

Current 3/29 tip fails on attachment.cgi when inserting an attachment using the
big file switch. This is not size dependent, as inserting into the db table
still works.

Results from effort are below:

Software error:

Undef to trick_taint at Bugzilla/Util.pm line 60
	Bugzilla::Util::trick_taint('undef') called at
/var/www/html/bugzilla2/attachment.cgi line 931
	main::insert('undef') called at /var/www/html/bugzilla2/attachment.cgi line 134

For help, please send mail to the webmaster ([e-mail]), giving this error
message and the time and date of the error. 

Reproducible: Always

Steps to Reproduce:
1. Go to existing bug report
2. Select 'Create a new attachment' link
3. Browse an select a file to attach to the bug record
4. With file selected in step 3, select the 'Big File' switch
5. Select other options as typical with non-Big File options (mime-type,
comments, etc)
6. Hit 'Submit' button, error as defined above will occur

Actual Results:  
Error as defined above

Expected Results:  
Attachment is created, stored in localhost directory with linky to retrieve.

Host is Fedora Core 3, Apache 2.0.52, Mysql 4.0.23, Perl 5.8.5, Bugzilla is
2.18rc3 updated through CVS to 2.19.2, then synced to the 3/30/05 tip. This
install is a default install used to verify bugs in custom install to determine
if bugs are introduced through customization.

Assumptions: local file directory does not appear to have been created through
checksetup.pl with appropriate perms. may be a good idea to insert into
localconfig a location where files can be stored, and ensure that checksetup.pl
assigns the appropriate perms for that directory.

For the big file feature, this is a blocker, as functionality does not work for
this install.

Comment 1

[Marc Schumann [:Wurblzap]]

Confirming, lowering severity because it's in an optional feature.

This is a regression of bug 285740 (not a perms or dir creation thing as
proposed in comment 0).

Comment 2

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 3

[Frédéric Buclin]

Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.80; previous revision: 1.79
done