288408 - Checksetup fails on new databases or on upgrades

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect, P1)

Description

[Joel Peshkin]

Bug 73665 broke checksetup for new databases.  It removed emailflags but did not
reduce the number fo placeholders.

(we should add a tinderbox test for starting from a blank DB)

Here's the culprit...

         $dbh->do(
           q{INSERT INTO profiles (login_name, realname, cryptpassword, 
-                                  emailflags, disabledtext, refreshed_when)
+                                  disabledtext, refreshed_when)
             VALUES (?, ?, ?, ?, ?, ?)},
             undef, $login, $realname, $cryptedpassword, 
-            Bugzilla::Constants::DEFAULT_EMAIL_SETTINGS, '', '1900-01-01
00:00:00');
+            '', '1900-01-01 00:00:00');

Comment 1

[Max Kanat-Alexander]

There is a tinderbox test for starting from a blank DB. It's just that it also
tries to compile the templates, so it's burning at that point, right now.

Comment 2

[Max Kanat-Alexander]

Oh, no, it's actually burning at this point, now. :-)

DBD::mysql::db do failed: You have an error in your SQL syntax near ')' at line
3 at ./checksetup.pl line 4222

Comment 3

[Gervase Markham [:gerv]]

Sorry :-(

I'm at work and can't do a patch. Can someone oblige? Email me and I'll r= it.

Gerv

Comment 4

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Here's the obvious fix. Joel or Max, can you r=?

Gerv

Comment 5

[Gervase Markham [:gerv]]

Fixed.

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.380; previous revision: 1.379
done

Gerv