288459 - Profile Manager window is truncated

Status: VERIFIED WORKSFORME

(Toolkit :: Startup and Profile System, defect)

Description

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050331
Firefox/1.0+
1. Start firefox with -p
2. Observe the profile manager window is not fully drawn, it is missing its buttons.

Comment 1

[Steve England [:stevee]]

Attachment: Screenshot of truncated profile manager

Comment 2

[Peter van der Woude [:Peter6]]

kwd regression
regressed between 20050330 07 and 20050331 07 builds

Comment 3

[Benjamin Smedberg]

I don't see anything obvious. Somebody's going to need to go through the layout
checkins to see why this regressed.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Is this also a problem in builds with bug 288117 backed out?

Comment 5

[Peter van der Woude [:Peter6]]

(In reply to comment #4)
> Is this also a problem in builds with bug 288117 backed out?

Yes !

Comment 6

[Boris Zbarsky [:bzbarsky]]

In that case I have no idea what in that regression range could possibly be
causing issues....

Comment 7

[Steve England [:stevee]]

(In reply to comment #4)
> Is this also a problem in builds with bug 288117 backed out?
For me, no.
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050331
Firefox/1.0+  firefox.exe timestamp Created 31 March 2005, 12:07:36

Comment 8

[Peter van der Woude [:Peter6]]

(In reply to comment #6)
> In that case I have no idea what in that regression range could possibly be
> causing issues....

(In reply to comment #5)
> (In reply to comment #4)
> > Is this also a problem in builds with bug 288117 backed out?
> 
> Yes !

Geez, I should have read the question properly.
No, the problem is gone with 288117 backed out.
(sorry)

Comment 9

[Benjamin Smedberg]

WFM

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This works OK for me in Seamonkey. I'll build Firefox to see if it was FF-only.

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I can reproduce it in Firefox. Great.

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This seems to have been caused by the fact that until its first reflow,
nsListBoxBodyFrame returns an incorrect prefsize because it doesn't know its
rowsize. So we end up sizing the dialog based on a prefsize for the listbox that
is quite wrong. The question is why this worked before.